Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add join-keepNamed option flag to optimize CLI #1550

Open
jo-chemla opened this issue Nov 7, 2024 · 1 comment
Open

Add join-keepNamed option flag to optimize CLI #1550

jo-chemla opened this issue Nov 7, 2024 · 1 comment
Labels
feature New enhancement or request package:cli
Milestone

Comments

@jo-chemla
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The current optimize CLi lacks the ability to define join options like keepNamed and keepMeshes. It only allows for a bool flag to enable or not join

Describe the solution you'd like
It could be useful to expose these flags to the optimize CLI.

Describe alternatives you've considered
Add the flag here in the cli.js script

.option('--join <bool>', 'Join meshes and reduce draw calls. Requires `--flatten`.', {

@jo-chemla
Copy link
Contributor Author

jo-chemla commented Nov 7, 2024

Just did a small PR to add these --join-keep-named and --join-keep-meshes flags: #1551

@donmccurdy donmccurdy added this to the v4.1 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New enhancement or request package:cli
Projects
None yet
Development

No branches or pull requests

2 participants