You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a follow on issue to #90 (I wasn't able to reopen my issue closed by someone else because I'm not a collaborator, I think).
Behavior
Fix #91 worked well for me when using a short name, but it does break when I use a fully qualified ref. I think that the filter logic here breaks down when shortName is fully qualified, e.g., if shortName == 'refs/remotes/origin/{branch_name}, then match[1] == '{branch_name}' when match !== null.
Maybe a fix?
I think that this can be fixed by modifying getShortName to also strip 'refs/remotes/origin' from the ref.
The text was updated successfully, but these errors were encountered:
This is a follow on issue to #90 (I wasn't able to reopen my issue closed by someone else because I'm not a collaborator, I think).
Behavior
Fix #91 worked well for me when using a short name, but it does break when I use a fully qualified ref. I think that the filter logic here breaks down when
shortName
is fully qualified, e.g., ifshortName == 'refs/remotes/origin/{branch_name}
, thenmatch[1] == '{branch_name}'
whenmatch !== null
.Maybe a fix?
I think that this can be fixed by modifying
getShortName
to also strip'refs/remotes/origin'
from theref
.The text was updated successfully, but these errors were encountered: