Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify .NET support is dotnet test command support #232

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

anatawa12
Copy link
Contributor

Improves #98

Currently, it's not clear that this action does not supports NUnit3 xml report so this PR clarifies .NET support is support for dotnet test command.

@zola-25
Copy link

zola-25 commented Sep 5, 2023

I think the README shouldn't list the .NET test frameworks much at all, it should really clarify from the start the test result formats it supports. This tool doesn't need to care about the test framework that was used.

I say this having skimmed the readme and thinking it supported the XUnit format, but on closer inspection it doesn't, and I've got to make some changes.

@jozefizso
Copy link
Collaborator

We must list the tools and their format of results because even though several toolsets use e.g. JUnit format, the actual output differs greatly between them.

@jozefizso jozefizso added the documentation Improvements or additions to documentation label Dec 18, 2023
@j-catania j-catania linked an issue Jan 12, 2024 that may be closed by this pull request
@jozefizso jozefizso added this to the v2.0.0 milestone Jun 25, 2024
@jozefizso jozefizso merged commit 2d69204 into dorny:main Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarification on if there is support for NUnit?
3 participants