Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target node20 #489

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Target node20 #489

merged 3 commits into from
Jun 25, 2024

Conversation

jozefizso
Copy link
Collaborator

Upgrades the TypeScript config to target NodeJS 20 runtime.
Also formalizes the minimal required node engine.

This fixes an issue with a regex in the dart flutter parser, as the /ms flag can be used only in the ES2018 target:

src/parsers/dart-json/dart-json-parser.ts:209:123 - error TS1501: This regular expression flag is only available when targeting 'es2018' or later.

209         /^══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═+\s+(.*)\s+When the exception was thrown, this was the stack:/ms

Fixes the error:

```
src/parsers/dart-json/dart-json-parser.ts:209:123 - error TS1501: This regular expression flag is only available when targeting 'es2018' or later.

209         /^══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═+\s+(.*)\s+When the exception was thrown, this was the stack:/ms
```
@jozefizso jozefizso added this to the v2.0.0 milestone Jun 25, 2024
@jozefizso jozefizso self-assigned this Jun 25, 2024
@jozefizso jozefizso merged commit e052c7d into main Jun 25, 2024
3 checks passed
@jozefizso jozefizso deleted the target-node20 branch June 25, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants