Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UVE: Support #editContentlet Macro in Universal Visual Editor #30218

Closed
fmontes opened this issue Oct 2, 2024 · 6 comments · Fixed by #30456, #30540 or #30657
Closed

UVE: Support #editContentlet Macro in Universal Visual Editor #30218

fmontes opened this issue Oct 2, 2024 · 6 comments · Fixed by #30456, #30540 or #30657

Comments

@fmontes
Copy link
Member

fmontes commented Oct 2, 2024

Problem Statement

The Universal Visual Editor (UVE) currently does not support the #editContentlet macro, which limits developers' ability to customize and edit contentlets within the editor.

Steps to Reproduce

  1. Open the Universal Visual Editor.
  2. Try to use the #editContentlet macro within the editor.
  3. Notice that the macro is not recognized or supported by the editor.

Acceptance Criteria

TBD

External Links

N/A

Assumptions & Initiation Needs

  • It is assumed that developers will need to utilize the #editContentlet macro for more dynamic content editing within the Universal Visual Editor.
  • Initiation needs include updating the UVE codebase to recognize and support the #editContentlet macro.

Quality Assurance Notes & Workarounds

  • Currently, developers can manually edit contentlets outside of the UVE to include the #editContentlet macro.
@fmontes fmontes moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Oct 2, 2024
@fmontes fmontes changed the title UVE: Support #editContentlet Macro in Universal Visual Editor UVE: Support #editContentlet Macro in Universal Visual Editor Oct 2, 2024
@mbiuki
Copy link
Contributor

mbiuki commented Oct 22, 2024

We also lost ability to reorder menus
@nollymar

@mbiuki mbiuki added Blocker This issue is blocking the release and removed Blocker This issue is blocking the release labels Oct 22, 2024
@zJaaal zJaaal self-assigned this Oct 23, 2024
@zJaaal zJaaal moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning Oct 23, 2024
@zJaaal zJaaal moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Oct 24, 2024
@zJaaal
Copy link
Contributor

zJaaal commented Oct 24, 2024

We will take care of the reorder menu macro in this ticket #30445

@zJaaal zJaaal linked a pull request Oct 25, 2024 that will close this issue
Copy link

github-actions bot commented Oct 25, 2024

@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Oct 30, 2024
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Oct 30, 2024
@zJaaal zJaaal removed their assignment Oct 31, 2024
@zJaaal zJaaal reopened this Oct 31, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Oct 31, 2024
@zJaaal zJaaal moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Oct 31, 2024
@zJaaal
Copy link
Contributor

zJaaal commented Oct 31, 2024

Note to QA

Headless

Right now this is only implemented in NextJS. It should work in any framework, but if you don't want to go and modify the code. You can just run the NextJS example, go to the footer and you should see an small edit button in the contentlets of the footer. Be aware, that we didn't take in count any styles or hide/show functionality, we only want it to work in this iteration. It should pop the edit contentlet and also refresh the contentlet on save. We have another issue to create components for this button and enhance the visual funcionality, this ticket also cover the integration in other frameworks

Edit Button

Screenshot 2024-10-31 at 10 42 29 AM

Traditional

In order to see the correct button in the page, you can go to application/vtl/blog/blog-listing.vltdelete the code from line 32 to line 36 and add the macro with the inode of contentlet as arguments. It should look something like: #editContentlet($con.inode)

And then you can test the button on the blog listing page /blog/index.

Visual Reference

You should see a pencil above the contentlet, with no title and nothing else but a pencil

Screenshot 2024-10-31 at 10 47 41 AM

@rjvelazco rjvelazco self-assigned this Oct 31, 2024
@rjvelazco
Copy link
Contributor

Passed IQA

  • Tested on docker image: [dotcms/dotcms:trunk_c0a01e6]

Traditional

30218-uve-support-editcontentlet-macro-in-universal-visual-editor-traditional.mov

Headless

30218-uve-support-editcontentlet-macro-in-universal-visual-editor-headless.mov

@rjvelazco rjvelazco removed their assignment Oct 31, 2024
@rjvelazco rjvelazco moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Oct 31, 2024
@zJaaal zJaaal linked a pull request Oct 31, 2024 that will close this issue
@zJaaal zJaaal linked a pull request Nov 14, 2024 that will close this issue
@bryanboza
Copy link
Member

Fixed, tested on the Next JS and Angular SDK and now we are able to use this macro as expected.

Issue related to button UI was created here: #30534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment