Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throttle connection creation #2637

Closed
mdaigle opened this issue Jul 1, 2024 · 0 comments · Fixed by #2667
Closed

Don't throttle connection creation #2637

mdaigle opened this issue Jul 1, 2024 · 0 comments · Fixed by #2667
Assignees
Labels
Area\ClientX Issues that are targeted for ClientX codebase.

Comments

@mdaigle
Copy link
Contributor

mdaigle commented Jul 1, 2024

Approach

We will:

Why is this the right approach?

  • The upgrade story is straightforward. Users who need to maintain the hard limit just add an app context switch.
  • Hard limits are easier to enforce with simple synchronization primitives and won't require us to take a dependency on polly or write complicated, custom retry logic.
  • Leaving space to extend the throttling capabilities via a plugin system will allow us to add this if/when we determine it is necessary. It may be that a hard limit is sufficient for most users who require throttling (it works for them today).
@mdaigle mdaigle added the Area\ClientX Issues that are targeted for ClientX codebase. label Jul 1, 2024
@mdaigle mdaigle self-assigned this Jul 1, 2024
@mdaigle mdaigle changed the title POC for connection open throttling Dynamically throttle connection opens Jul 1, 2024
@mdaigle mdaigle linked a pull request Jul 15, 2024 that will close this issue
@mdaigle mdaigle changed the title Dynamically throttle connection opens Don't throttle connection creation Jul 19, 2024
@mdaigle mdaigle closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\ClientX Issues that are targeted for ClientX codebase.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant