Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Support : Optimize writing large JSON data by sending chunks #2732

Open
apoorvdeshmukh opened this issue Jul 30, 2024 · 1 comment
Open
Assignees
Labels
Area\Json Issues that are targeted for the Json feature in the driver.

Comments

@apoorvdeshmukh
Copy link
Contributor

This issue is to track the follow-up work needed for JSON write performance optimization as suggested here in this thread.

We need to either use the convert function or Encoder instance for the optimization as suggested here and here.

@apoorvdeshmukh apoorvdeshmukh self-assigned this Jul 30, 2024
@cheenamalhotra cheenamalhotra added the Area\ClientX Issues that are targeted for ClientX codebase. label Jul 30, 2024
@Wraith2
Copy link
Contributor

Wraith2 commented Jul 31, 2024

I'm not sure this is a ClientX feature, it's part of the main sql client json support.

I had a thought. If every packet array that was created was just slightly larger than we really needed then we could always write directly into the packet buffer and only copy out any remainder bytes that we need to keep. It would only need+3 bytes to each packet. The downside is that this would be a constant additional cost even when users aren't using json so it isn't pay-for-play.

@saurabh500 saurabh500 added Area\Json Issues that are targeted for the Json feature in the driver. and removed Area\ClientX Issues that are targeted for ClientX codebase. labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Json Issues that are targeted for the Json feature in the driver.
Projects
None yet
Development

No branches or pull requests

4 participants