Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With parameter groups introduced in managed code, revert previous optimizers to native code. #531

Closed
NiklasGustafsson opened this issue Feb 22, 2022 · 0 comments
Closed

With parameter groups introduced in managed code, revert previous optimizers to native code. #531

NiklasGustafsson opened this issue Feb 22, 2022 · 0 comments
Assignees
@NiklasGustafsson

Comments

@NiklasGustafsson
Copy link
Contributor

NiklasGustafsson commented Feb 22, 2022 •
edited
Loading

Implementing parameter group support in one way across all optimizers seemed like the easier thing to do. It is, however, worth considering reverting the optimizers that were implemented in native code, even if that means having two different approaches in the solution.

See: #523 (comment)
@NiklasGustafsson NiklasGustafsson mentioned this issue Feb 22, 2022
Merged
@NiklasGustafsson NiklasGustafsson self-assigned this Feb 22, 2022
@NiklasGustafsson NiklasGustafsson closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiklasGustafsson NiklasGustafsson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NiklasGustafsson