Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind "androidx.media3" #710

Closed
ivs88 opened this issue Mar 24, 2023 · 21 comments · Fixed by #779
Closed

Bind "androidx.media3" #710

ivs88 opened this issue Mar 24, 2023 · 21 comments · Fixed by #779
Assignees
Labels
in-progress in progress new-package-request Request for a new package to be bound

Comments

@ivs88
Copy link

ivs88 commented Mar 24, 2023

Description

Media3 is stable now!
https://developer.android.com/jetpack/androidx/releases/media3

@ivs88 ivs88 added the new-package-request Request for a new package to be bound label Mar 24, 2023
@moljac moljac added the in-progress in progress label May 12, 2023
@moljac moljac self-assigned this May 16, 2023
@Soap-141
Copy link

Any news on this?

@moljac
Copy link
Contributor

moljac commented Jul 24, 2023

Any news on this?

I made some progress, but still quite a lot to do.

@ivs88
Copy link
Author

ivs88 commented Jul 24, 2023

Any news on this?

I made some progress, but still quite a lot to do.

Just in case this helps there is this project with ExoPlayer bindings https://github.com/Baseflow/ExoPlayerXamarin

@thomasphillipsgb
Copy link

Howdy, sorry to be that guy. Has there been any progress made on this?

Specifically I wish to consume the Media3.Transformer set of classes. Or if anyone knows of an alternative that can be used in the meantime.

Much appreciated.

@ArchangelWTF
Copy link

@Maxgamerboy1 There's a PR that I've made in ExoPlayerXamarin Baseflow/ExoPlayerXamarin#166 that should fully work for most stuff Media3, when Media3 finally gets it's bindings here it should be fully compatible too due to having no changing namespaces.

@moljac If it's any help feel free to take from those bindings as well, I'd also be glad to help out in binding Media3 if it's needed.

@moljac
Copy link
Contributor

moljac commented Oct 4, 2023

Howdy, sorry to be that guy.

Someone has to be that guy, but it is OK.

Has there been any progress made on this?

Yes. I managed to grab some extra time to finish it in last few weeks.

@moljac
Copy link
Contributor

moljac commented Oct 4, 2023

@moljac If it's any help feel free to take from those bindings as well, I'd also be glad to help out in binding Media3 if it's needed.

@ArchangelWTF Thanks a lot. I will take a look for sure.

@tipa
Copy link

tipa commented Dec 7, 2023

Happy to see this is being worked on! Is there any estimate on how long it might take approx. until it's released? Just so that I can decide if I should try to bind it myself based on the existing branch or if I should rather wait for the official bindings

@moljac
Copy link
Contributor

moljac commented Dec 15, 2023

Happy to see this is being worked on!

I wish I could do it faster, but

Is there any estimate on how long it might take approx. until it's released?

I have some troubles with idioms. I could nuke (remove-node), but my religious beliefs are against it.

Just so that I can decide if I should try to bind it myself based on the existing branch or if I should rather wait for the official bindings

You can try and teach me.

I hope - january. Holidays and I need mental challenge to heal my PTSD.

@moljac
Copy link
Contributor

moljac commented Jan 4, 2024

Almost done. Few weird issues I am investigating, but...

#779

@moljac moljac linked a pull request Mar 2, 2024 that will close this issue
@moljac
Copy link
Contributor

moljac commented Mar 2, 2024

Ready for review.

Release most likely next week

@FreakyAli
Copy link

@moljac This is awesome, please let me know when this is out I plan on working on a .NET MAUI Lib for this

@moljac
Copy link
Contributor

moljac commented Jul 30, 2024

Published

https://www.nuget.org/packages?q=AndroidX.Media3

@tipa
Copy link

tipa commented Jul 31, 2024

Thanks for releasing @moljac! Looks like this wasn't the most trivial package to bind :)

I am planning to use the AndroidX.Media3.Transformer package to transcode video & audio.
Unfortunately, I am hitting a problem right away, when trying to follow the guides from Google: https://developer.android.com/media/media3/transformer/getting-started#start

var inputMediaItem = MediaItem.FromUri(uri);
var editedMediaItem = new EditedMediaItem.Builder(inputMediaItem).SetRemoveAudio(true).Build();

The EditedMediaItem class doesn't seem to be present (not bound?), the same seems to be the case for many other classes in the same package/namespace. Am I missing something or is this still work in progress?

@ne0rrmatrix
Copy link
Contributor

I noticed that IPlayer.IListener is missing? Unless it was replaced with IPlayerListener?

@moljac
Copy link
Contributor

moljac commented Aug 4, 2024

Sorry for late answer

Thanks for releasing @moljac! Looks like this wasn't the most trivial package to bind :)

True. Started more than 15 months ago. Maybe 18. As sideproject. I recall 900+ errors. OK, it was 2 TFMs so 400+. I did hit all kinds of issues, but our tooling got better. The worst was context switching when coming back after few days/weeks: where was I? Even had thoughts to restart everythng. At the end JPobst did clean restart with my metdata and we were able to finish it.

I am planning to use the AndroidX.Media3.Transformer package to transcode video & audio. Unfortunately, I am hitting a problem right away, when trying to follow the guides from Google: https://developer.android.com/media/media3/transformer/getting-started#start

var inputMediaItem = MediaItem.FromUri(uri);
var editedMediaItem = new EditedMediaItem.Builder(inputMediaItem).SetRemoveAudio(true).Build();

Please open the issue.

The EditedMediaItem class doesn't seem to be present (not bound?),

Could be. I did resort to remove-node quite a lot and I don't like it, but I didn't have time.

the same seems to be the case for many other classes in the same package/namespace. Am I missing something or is this still work in progress?

Most likely my shortcuts. I need to check, so please open the issue with minimal repro sample and maybe list of missing types.

@moljac
Copy link
Contributor

moljac commented Aug 4, 2024

I noticed that IPlayer.IListener is missing?

Could be. I am not SDK expert. PLease open the issue, so I can track it.

Unless it was replaced with IPlayerListener?

Not sure. I have no ideas about media3 APIs. Sorry.

@tipa
Copy link

tipa commented Aug 15, 2024

@moljac I created an issue here

@moljac
Copy link
Contributor

moljac commented Aug 16, 2024

@moljac I created an issue here

Danke @tipa

I saw that one. I will take a look.

@ArchangelWTF
Copy link

I noticed that IPlayer.IListener is missing? Unless it was replaced with IPlayerListener?

It's replaced with IPlayerListener

@ne0rrmatrix
Copy link
Contributor

Im hoping on the next build released that this is fixed. ATM the listener does not work. I tested against another library that I can't use to see if it was my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress in progress new-package-request Request for a new package to be bound
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants