Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xunit-reporter needs to use venv for cross-architecture scenarios #5786

Closed
2 tasks
MattGal opened this issue Jul 14, 2020 · 14 comments
Closed
2 tasks

Xunit-reporter needs to use venv for cross-architecture scenarios #5786

MattGal opened this issue Jul 14, 2020 · 14 comments
Assignees

Comments

@MattGal
Copy link
Member

MattGal commented Jul 14, 2020

  • This issue is blocking
  • This issue is causing unreasonable pain

Example log

As noted in dotnet/runtime#39244 . When Xunit-reporter was created, we didn't have any ARM arch docker machines (or even docker support, for that matter). As such, it tries to use the mounted-in python packages including native bits from the host machine, which may or may not work inside the docker container (for instance, in the case of ARM32 on ARM64, definitely not).

There's an existing pattern that can be followed used by the azure devops reporter in the same Helix SDK, which is to use Venv to run it (instead of just straight "python"). (See https://github.com/dotnet/arcade/tree/master/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/reporter )

@garath
Copy link
Member

garath commented Jul 16, 2020

Triage: We plan to talk about this more under the context of the Resiliency effort.

@markwilkie
Copy link
Member

This is telemetry used by us. Is there another path you could take to get what you need? Taking a dependency on our Kusto db may not be the best path forward.

cc/ @Chrisboh

@BruceForstall
Copy link
Member

Maybe I'm mistaken about the impact of the failure? I thought from the description it was preventing test results from being included in the Kusto data which I regularly use to determine how frequently a test fails and how wide the impact is of a particular test failing. I use https://dataexplorer.azure.com/clusters/engsrvprod/databases/engineeringdata for that. When you say "taking a dependency on our Kusto db", is that the one you are talking about?

@markwilkie
Copy link
Member

I think so - but @Chrisboh can confirm. I'm wondering if there's a better way to do this... What are you using the data for from kusto?

@BruceForstall
Copy link
Member

I (and others) use the data to analyze test failures, especially "flaky" test failures. E.g., how often does test A fail? In which pipelines does it fail? On what architectures does it fail? Kusto is, of course, very flexible, and that flexibility is very useful when doing this kind of work. It's MUCH better for this than simply using the AzDO UI, which is extremely lacking in this kind flexible analysis capability.

@MattGal
Copy link
Member Author

MattGal commented Sep 28, 2020

@lukas-lansky any update?

@lukas-lansky
Copy link
Contributor

@MattGal I will open the PR today.

@ilyas1974
Copy link
Contributor

@lukas-lansky is there any information you can add to this issue regarding the PR you created? Is this issue still a problem?

@lukas-lansky
Copy link
Contributor

@ilyas1974 The PR should solve the issue. Let me find someone who will help me review that and maybe provide additional context. (Also, I'm on FR next week luckily.)

@lukas-lansky lukas-lansky self-assigned this Nov 5, 2020
@ChadNedzlek
Copy link
Member

We are likely going to remove this reporter as part of our resiliency effort. https://github.com/dotnet/core-eng/issues/11347 (As part of that, we are also only going to record failures as individual data items).

I'm curious what sorts of reporting you are doing, because we are trying to figure out a way to only store aggregated data so that people can still be productive without us having to shuttle terabytes of data around that is mostly useless.

@BruceForstall
Copy link
Member

I had a long conversation with @Chrisboh about this. Bottom-line: this problem means linux-arm failures don't get reported, and we can't use Kusto to see trends in test failures.

@lukas-lansky
Copy link
Contributor

lukas-lansky commented Nov 12, 2020

I verified with @alexperovich that the work is being done on removal of the problematic code. I closed my PR and I'm moving this to Tracking as discussed yesterday on FR standup. We can close this as soon as Alex's work is done without any change specific to this issue.

@lukas-lansky
Copy link
Contributor

The work is now being tracked in https://github.com/dotnet/core-eng/issues/11793.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants