Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wix _GenerateMsiVersionString should be usable with the signed wix packages for workloads #8076

Open
lewing opened this issue Oct 20, 2021 · 1 comment

Comments

@lewing
Copy link
Member

lewing commented Oct 20, 2021

<Target Name="_GenerateMsiVersionString">

.NET workload manifests need a way to generate correct msi versions but can't easily use the current _GenerateMsiVersionString wix target so we've had to duplicate the target in:

We'd like to get rid of that duplication and use shared code

cc @steveisok @joeloff @mmitche

@AraHaan
Copy link
Member

AraHaan commented Dec 6, 2021

That is not the only thing I do not like about the msi gen in arcade:

For starters people outside of the .NET Foundation (me) use the arcade to build msi installers for windows and they incorrectly get stamped with:

  • Copyright: Microsoft Corporation

by default instead of their own copyright setting.

Hopefully the macos pkg gen does not have that issue as well too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants