Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspire template option misspelling #1018

Closed
hammar opened this issue Nov 24, 2023 · 1 comment · Fixed by #1019
Closed

Aspire template option misspelling #1018

hammar opened this issue Nov 24, 2023 · 1 comment · Fixed by #1019
Labels
area-templates

Comments

@hammar
Copy link

hammar commented Nov 24, 2023 •
edited
Loading

Hi,

I just noticed the below that might need fixing (apiSerivceHttpPort -> apiServiceHttpPort, same for the corresponding Https option):

https://github.com/dotnet/aspire/blob/fd3c41b30dd76c10c7c91c8d8c8815c0e918df0e/src/Aspire.ProjectTemplates/templates/aspire-starter/.template.config/template.json#L210C7-L210C7

Happy to submit a PR after Thanksgiving weekend, if you don't prefer to fix it yourselves.

Cheers,

Karl
@kiapanahi kiapanahi mentioned this issue Nov 24, 2023
Merged
@kiapanahi
Copy link
Contributor

Noticed this myself. Came to create an issue and saw yours. #1019 fixes it.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in aspire-starter template kiapanahi/aspire
3 participants
@hammar @davidfowl @kiapanahi