Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EffectiveEnv for ContainerViewModel computation #1114

Closed
smitpatel opened this issue Nov 29, 2023 · 2 comments · Fixed by #1288
Closed

Use EffectiveEnv for ContainerViewModel computation #1114

smitpatel opened this issue Nov 29, 2023 · 2 comments · Fixed by #1288
Assignees
@drewnoakes
Labels
area-dashboard enhancement An enhancement to an existing feature or capability.

Comments

@smitpatel
Copy link
Member

We are adding EffectiveEnv for Containers in dcp now, we need to start consuming it for ContainerViewModel.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Nov 29, 2023
@smitpatel smitpatel added area-dashboard enhancement An enhancement to an existing feature or capability. and removed area-integrations Issues pertaining to Aspire Integrations packages labels Nov 29, 2023
@karolz-ms karolz-ms mentioned this issue Dec 11, 2023
Merged
@drewnoakes
Copy link
Member

@smitpatel what's the desired approach here? Should we replace use of Env with EffectiveEnv or do we want to merge/fallback somehow?

@drewnoakes
Copy link
Member

drewnoakes commented Dec 11, 2023 •
edited
Loading

It's ok, I worked this out.

EffectiveEnv is available on the container status message.

While debugging this I found that the code we were using to call docker to get the effective environment variables was not working anyway. I'm removing it and using the data from DCP instead in #1288 (in 0f0b74b).

@drewnoakes drewnoakes self-assigned this Dec 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@drewnoakes drewnoakes

Labels
area-dashboard enhancement An enhancement to an existing feature or capability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract all data acquisition from ResourceService drewnoakes/aspire
2 participants
@drewnoakes @smitpatel