Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background to the expander headers in the new resource details panel #1612

Closed
kvenkatrajan opened this issue Jan 9, 2024 · 3 comments · Fixed by #2270
Closed

Add background to the expander headers in the new resource details panel #1612

kvenkatrajan opened this issue Jan 9, 2024 · 3 comments · Fixed by #2270
Assignees

Comments

@kvenkatrajan
Copy link
Member

A follow up suggestions to #1542 :
#1542 (comment)
#1542 (comment)

Add a background to the expander headers for better section visibility.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jan 9, 2024
@JamesNK
Copy link
Member

JamesNK commented Jan 9, 2024

The accordion originally had a lot more stuff to separate sections. Different background colors for headers, borders, etc. I turned it off because it didn't look good.

I've slightly increased the gap between each section (4px to 8px) to help highlight them:
image

@kvenkatrajan
Copy link
Member Author

For example the background for each section header itself being a different color:
image
or indented
image

@DamianEdwards DamianEdwards added area-dashboard and removed area-integrations Issues pertaining to Aspire Integrations packages labels Jan 10, 2024
@leslierichardson95
Copy link

I'm team indentation and different header color :)

@kvenkatrajan kvenkatrajan added this to the preview 4 (Mar) milestone Feb 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants