Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow resource properties to be marked as secret #5065

Closed
Tracked by #2415
drewnoakes opened this issue Jul 24, 2024 · 5 comments · Fixed by #5380
Closed
Tracked by #2415

Allow resource properties to be marked as secret #5065

drewnoakes opened this issue Jul 24, 2024 · 5 comments · Fixed by #5380
Assignees
@drewnoakes
Labels
area-dashboard security 🔐
Milestone
9.0

Comments

@drewnoakes
Copy link
Member

drewnoakes commented Jul 24, 2024 •
edited
Loading

Today, environment variables are shown in the UI as a series of dots (like a password mask) and the user must flip a toggle to show them. This prevents accidental disclosure to onlookers, such as when screen sharing.

We should add the same facility to resource properties, and allow each property to define whether it is a secret or not. Such secret properties would be displayed as masked in the UI by default.
@drewnoakes drewnoakes mentioned this issue Jul 24, 2024
Closed
6 tasks
@drewnoakes drewnoakes added this to the 8.2 milestone Jul 24, 2024
@drewnoakes drewnoakes self-assigned this Jul 24, 2024
@drewnoakes drewnoakes changed the title Add support for properties to express if they are a secret are not (and therefore should be masked). This is useful for showing things like connection strings in the list of properties. Allow resource properties to be marked as secret Jul 24, 2024
@drewnoakes
Copy link
Member Author

Pulled out of #2415.

@joperezr
Copy link
Member

@drewnoakes is this on track for 8.2 milestone or should it get pushed?

@drewnoakes
Copy link
Member Author

I'm working towards 8.2, yes.

@drewnoakes
Copy link
Member Author

Work here is likely to conflict with #5266.

This was referenced Aug 19, 2024
Open
Merged
@drewnoakes
Copy link
Member Author

PR in review #5380

@drewnoakes drewnoakes modified the milestones: 8.2, 9.0 Aug 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@drewnoakes drewnoakes

Labels
area-dashboard security 🔐
Projects
None yet
Milestone
9.0
Development

Successfully merging a pull request may close this issue.

Allow resource properties to be marked as secret drewnoakes/aspire
4 participants
@davidfowl @drewnoakes @danmoseley @joperezr