Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easy to identify services are logging errors on the projects/executables pages #533

Closed
1 of 3 tasks
davidfowl opened this issue Oct 26, 2023 · 6 comments · Fixed by #1378
Closed
1 of 3 tasks
Assignees

Comments

@davidfowl
Copy link
Member

davidfowl commented Oct 26, 2023

As a follow up to #227, we've received more feedback that a similar strategy could be applied to the projects/executables overview page to make it easier to know what to do next when things are happening with their service. The only thing that the dashboard has today are logs, and the state of the process (we don't yet have health checks integrated).

  • - Change the background color and use an icon for services that are finished state (not sure which one).
  • - If a process exits with a non-zero exit code (finished state with non zero exit code), show an error icon. (same pattern as an error log)
  • - When a service logs and error (via structured logging), show an indicator that there are errors in the log with a link to navigate to a filtered view of that service with just the error logs. This indicator clears once the logs are viewed.
@JamesNK
Copy link
Member

JamesNK commented Oct 26, 2023

I like this.

A problem is we’re out of room in the project grid. Either we replace some columns (the console log button could go) or move that detail to a new project detail page

@davidfowl
Copy link
Member Author

Look at how hard it is to see Finished here:

image

@JamesNK
Copy link
Member

JamesNK commented Oct 27, 2023

I'm doing the third point.

@tlmii @smitpatel Can you look at 1 & 2?

@dbreshears dbreshears added this to the some time after preview milestone Oct 30, 2023
@dbreshears
Copy link
Contributor

Moving to after Preview as we need to discuss design a bit more for 1&2

@danmoseley danmoseley removed this from the needs milestone (for GA) milestone Nov 13, 2023
@kvenkatrajan
Copy link
Member

@smitpatel with the revised API for logs is there a way to indicate the states of 1,2 in the response back to the dashboard for display?

CC: @adamint

@smitpatel
Copy link
Member

There is nothing much related to revised API here, data is already there for most part. Purely UI concern. For exit codes, I will check if we get it from dcp.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants