Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only create the temp directory if we're going to launch DCP #687

Closed
davidfowl opened this issue Nov 3, 2023 · 0 comments · Fixed by #1014
Closed

Only create the temp directory if we're going to launch DCP #687

davidfowl opened this issue Nov 3, 2023 · 0 comments · Fixed by #1014
Assignees
@davidfowl
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication good first issue Good for newcomers help wanted Issue that is a good candidate for community contribution.
Milestone
preview 2 (Dec)

Comments

@davidfowl
Copy link
Member

Today we create the temp directory on creation of the DAB (DistributedApplicationBuilder), we should only create it when writing to the temp location.
@davidfowl davidfowl added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Nov 3, 2023
@danmoseley danmoseley added this to the some time after preview milestone Nov 3, 2023
@danmoseley danmoseley added good first issue Good for newcomers help wanted Issue that is a good candidate for community contribution. labels Nov 12, 2023
@danmoseley danmoseley removed this from the needs milestone (for GA) milestone Nov 13, 2023
@stbau04 stbau04 mentioned this issue Nov 23, 2023
Merged
@davidfowl davidfowl added this to the preview 2 (Dec) milestone Nov 24, 2023
@davidfowl davidfowl self-assigned this Nov 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidfowl davidfowl

Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication good first issue Good for newcomers help wanted Issue that is a good candidate for community contribution.
Projects
None yet
Milestone
preview 2 (Dec)
Development

Successfully merging a pull request may close this issue.

Create temp directory only if necessary stbau04/aspire
2 participants
@davidfowl @danmoseley