Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker projects get generated with http and https bindings #743

Closed
davidfowl opened this issue Nov 8, 2023 · 0 comments · Fixed by #859
Closed

Worker projects get generated with http and https bindings #743

davidfowl opened this issue Nov 8, 2023 · 0 comments · Fixed by #859
Assignees
@mitchdenny
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Milestone
preview 2 (Dec)

Comments

@davidfowl
Copy link
Member

Worker projects get generated in the manifest as if they have http and https bindings. Today we discard the launch settings when generating the manifest and assume all projects are ASP.NET Core projects with an endpoint. This fails in to run in aca if the app isn't listening on the port it says it is (by default 8080).
@davidfowl davidfowl added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Nov 8, 2023
@danmoseley danmoseley added this to the preview 2 milestone Nov 13, 2023
@mitchdenny mitchdenny self-assigned this Nov 15, 2023
@mitchdenny mitchdenny mentioned this issue Nov 16, 2023
Merged
@davidfowl davidfowl added the bug label Nov 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mitchdenny mitchdenny

Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
preview 2 (Dec)
Development

Successfully merging a pull request may close this issue.

Don't inject bindings at manifest generation for worker projects. dotnet/aspire
3 participants
@davidfowl @mitchdenny @danmoseley