Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor API Review: Microsoft.AspNetCore.Components.Web #12329

Closed
rynowak opened this issue Jul 18, 2019 · 0 comments
Closed

Blazor API Review: Microsoft.AspNetCore.Components.Web #12329

rynowak opened this issue Jul 18, 2019 · 0 comments
Assignees
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed

Comments

@rynowak
Copy link
Member

rynowak commented Jul 18, 2019

Summary

Microsoft.AspNetCore.Components.Web is our home for all things HTML-specific in Blazor.

This means any components that generate HTML here - as well as HTML-specific concepts like our event-args types and event handler definitions. The goal is to try and prevent HTML-specific concepts from showing up when Blazor is used with other pixel stacks.

Additionally, I'm recommending that we keep IUrlHelper and the routing system in the main components package. Not all UI stacks have the concept of URLs and routers, but some that aren't HTML do have it.

Importantly, it's possible to move things to .Web now and then back to .Components in the future if necessary. We can't do the opposite without breaking changes.

Changes

Forms Components (input, form, validation summary, validation message)

  • EditContext + Validation Stay

NavLink

UIEventArgs types

  • UIEventArgs + UIChangeEventArgs Stay
  • Everything else moves
  • BindAttributes.cs
  • EventHandlers.cs
  • BindInputElementAttribute.cs
  • EventCallbackFactoryUIEventArgsExtensions

HtmlRenderer + ComponentRenderedText

@rynowak rynowak added area-blazor Includes: Blazor, Razor Components API Review labels Jul 18, 2019
@rynowak rynowak added this to the 3.0.0-preview8 milestone Jul 18, 2019
@rynowak rynowak self-assigned this Jul 18, 2019
@danroth27 danroth27 mentioned this issue Jul 18, 2019
20 tasks
@rynowak rynowak added Done This issue has been fixed and removed Working labels Jul 21, 2019
@rynowak rynowak closed this as completed Jul 21, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed
Projects
None yet
Development

No branches or pull requests

1 participant