Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup u8 string literal workarounds #41455

Closed
BrennanConroy opened this issue Apr 30, 2022 · 2 comments · Fixed by #42995
Closed

Cleanup u8 string literal workarounds #41455

BrennanConroy opened this issue Apr 30, 2022 · 2 comments · Fixed by #42995
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework clean-up This issue is internal clean-up and has no effect on public APIs or expected behaviors
Milestone
7.0-rc1

Comments

@BrennanConroy
Copy link
Member

Changes that can be cleaned up are introduced in #41449. CertificateManager and DataProtectionTests were the areas affected.

Improvements to the u8 string literal feature are being tracked in dotnet/roslyn#60644
@BrennanConroy BrennanConroy added the clean-up This issue is internal clean-up and has no effect on public APIs or expected behaviors label Apr 30, 2022
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 2, 2022
@DamianEdwards
Copy link
Member

This is causing issues in Visual Studio in release/6.0 now as well. I've applied the required fixes in branch dedward/41529-template-namespace

@wtgodbe
Copy link
Member

wtgodbe commented May 31, 2022 •
edited
Loading

@BrennanConroy looks like the roslyn work was done in dotnet/roslyn#61532, so we should be able to do the reaction soon (hopefully after the next SDK update). Should I assign you?

@BrennanConroy BrennanConroy mentioned this issue Jul 29, 2022
Merged
@BrennanConroy BrennanConroy added this to the 7.0-rc1 milestone Aug 1, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework clean-up This issue is internal clean-up and has no effect on public APIs or expected behaviors
Projects
None yet
Milestone
7.0-rc1
Development

Successfully merging a pull request may close this issue.

Cleanup u8 workarounds dotnet/aspnetcore
4 participants
@DamianEdwards @Pilchie @BrennanConroy @wtgodbe