Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dotnet/extensions scenarios in ASP.NET metrics middleware #48666

Closed
noahfalk opened this issue Jun 8, 2023 · 1 comment
Closed

Handle dotnet/extensions scenarios in ASP.NET metrics middleware #48666

noahfalk opened this issue Jun 8, 2023 · 1 comment
Assignees
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Comments

@noahfalk
Copy link
Member

noahfalk commented Jun 8, 2023

We recently added metrics middleware support to ASP.NET, and dotnet/extensions also introduced alternative middleware. Ideally we handle that in a way that feels like customization or composition, not just picking between multiple alternative implementations that differ along multiple dimensions.

The important things dotnet/extensions wants to support:

  • Enriching the metrics with additional custom tags
  • Changing the metric name and tag names to support alternate naming schemas
  • dotnet/extensions wants to combine method and route. Can we do that by default or does that need to be a customization? Their telemetry PM asserts queries on just one isn’t very useful.

The output here would be some prototype, sample, or doc that demonstrates how we plan to handle this and what the experience is for users. There may or may not be runtime changes needed.

cc @geeknoid @dpk83 @JamesNK @antonfirsov

@noahfalk noahfalk changed the title Handle R9 scenarios in ASP.NET metrics middleware Handle dotnet/extensions scenarios in ASP.NET metrics middleware Jun 8, 2023
@JamesNK
Copy link
Member

JamesNK commented Jul 7, 2023

I've written an internal doc that merges ASP.NET Core changes with dotnet/extensions functionality. All required changes in ASP.NET Core for metrics have been made.

The next step is updating dotnet/extensions. I've created an issue there: dotnet/extensions#4154

@JamesNK JamesNK closed this as completed Jul 7, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

No branches or pull requests

3 participants