Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate metrics endpoint behavior when exception middleware runs #52648

Closed
1 task done
JamesNK opened this issue Dec 8, 2023 · 6 comments · Fixed by #52652
Closed
1 task done

Investigate metrics endpoint behavior when exception middleware runs #52648

JamesNK opened this issue Dec 8, 2023 · 6 comments · Fixed by #52652
Assignees
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Comments

@JamesNK
Copy link
Member

JamesNK commented Dec 8, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

OTEL folks noticed that the endpoint is cleared when exception middleware runs. See open-telemetry/opentelemetry-dotnet#5134

Investigate whether this impacts ASP.NET Core's use of the endpoint when building tags for metrics.

Expected Behavior

Metrics endpoint route tag is present when exception middleware runs.

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

net8.0

Anything else?

No response

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Dec 8, 2023
@JamesNK JamesNK added area-hosting Includes Hosting and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Dec 8, 2023
@davidroth
Copy link

Thanks, just reported this also in #52766 (duplicate) 👍

Question: Will this be published in an 8.0 release update or do we have to wait for 9.0? (Hoping for the former)

@JamesNK
Copy link
Member Author

JamesNK commented Dec 13, 2023

The fix will be back ported to 8.0.2 (available approx Feb or March)

@JamesNK
Copy link
Member Author

JamesNK commented Dec 13, 2023

Your issue here - #52766 - says the counter is muted. What do you mean by that? With the bug here, I would still expect a value to be recorded, but without a http_route value.

@davidroth
Copy link

Your issue here - #52766 - says the counter is muted. What do you mean by that? With the bug here, I would still expect a value to be recorded, but without a http_route value.

My fault. I retested it again and the value is indeed recorded, but without the http_route value. So basically as described in this issue.

@JamesNK
Copy link
Member Author

JamesNK commented Dec 13, 2023

Reopen to track backport to 8.0

@JamesNK JamesNK reopened this Dec 13, 2023
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@mkArtakMSFT mkArtakMSFT added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-hosting Includes Hosting labels Mar 6, 2024
@JamesNK
Copy link
Member Author

JamesNK commented Mar 7, 2024

Added to backport with #52790.

@JamesNK JamesNK closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants