Use System.Threading.Lock throughout ASP.NET Core

[JamesNK]

Is there an existing issue for this?

• I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

.NET 9 added a new lock type: dotnet/runtime#34812. The benefits are some small performance improvements, and disambiguation about locking on any type.

We should see if we can use this in ASP.NET Core. Could be performance gains in lock heavy code.

Describe the solution you'd like

The new type is only available in .NET 9 or later. However, some ASP.NET Core code targets back to .NET standard. It's not as simple as updating private static readonly object _lock fields with the Lock type because of this.

We could add a shim Lock type that is conditionally included in older targets. A shim type would avoid spreading #ifdefs throughout the code.

Additional context

No response

[ladeak]

Http2OutputProducer and Http2FrameWriter could very-well benefit from this, and it is using non-static fields like private readonly object _writeLock = new object();

[JamesNK]

Yes, they would be ideal candidates. I used static in the example, but any object fields that are just for locking could be updated.

[elachlan]

I've raised an issue for an analyzer rule at: dotnet/runtime#106907