Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use System.Threading.Lock throughout ASP.NET Core #56794

Open
1 task done
JamesNK opened this issue Jul 15, 2024 · 3 comments · May be fixed by #57968
Open
1 task done

Use System.Threading.Lock throughout ASP.NET Core #56794

JamesNK opened this issue Jul 15, 2024 · 3 comments · May be fixed by #57968
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Perf

Comments

@JamesNK
Copy link
Member

JamesNK commented Jul 15, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

.NET 9 added a new lock type: dotnet/runtime#34812. The benefits are some small performance improvements, and disambiguation about locking on any type.

We should see if we can use this in ASP.NET Core. Could be performance gains in lock heavy code.

Describe the solution you'd like

The new type is only available in .NET 9 or later. However, some ASP.NET Core code targets back to .NET standard. It's not as simple as updating private static readonly object _lock fields with the Lock type because of this.

We could add a shim Lock type that is conditionally included in older targets. A shim type would avoid spreading #ifdefs throughout the code.

Additional context

No response
@JamesNK JamesNK added the Perf label Jul 15, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jul 15, 2024
@JamesNK JamesNK mentioned this issue Jul 15, 2024
Closed
1 task
@ladeak
Copy link
Contributor

ladeak commented Jul 15, 2024

Http2OutputProducer and Http2FrameWriter could very-well benefit from this, and it is using non-static fields like private readonly object _writeLock = new object();

@JamesNK
Copy link
Member Author

JamesNK commented Jul 15, 2024

Yes, they would be ideal candidates. I used static in the example, but any object fields that are just for locking could be updated.

@elachlan
Copy link

I've raised an issue for an analyzer rule at: dotnet/runtime#106907

@ladeak ladeak mentioned this issue Aug 8, 2024
Merged
@ladeak ladeak linked a pull request Sep 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using Interlocked in InputFlowControl and Http2Stream ladeak/aspnetcore
3 participants
@JamesNK @elachlan @ladeak