Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --native-subdirectory when NuGet contentFiles become available #4732

Closed
brthor opened this issue Jan 6, 2016 · 3 comments
Closed

Remove --native-subdirectory when NuGet contentFiles become available #4732

brthor opened this issue Jan 6, 2016 · 3 comments
Assignees
@brthor
Labels
Bug
Milestone
1.0.0-rtm

Comments

@brthor
Copy link
Contributor

brthor commented Jan 6, 2016

When dotnet restore is shifted to NuGet x-plat, and the contentFiles nuspec option is available, we should remove the changes enabling --native-subdirectory publish option.

This option was intended to be a stopgap measure for including subdirectories from a nugget dependency in publish output.

Associated Publish Changes:
dotnet/cli#469

Build Changes that should be removed:
dotnet/cli#675
@brthor brthor self-assigned this Jan 6, 2016
@TheRealPiotrP
Copy link
Contributor

@brthor content is available. Can we make progress on this?

@brthor
Copy link
Contributor Author

brthor commented Jul 27, 2016

We should simply remove this in the msbuild publish implementation.

@livarcocc
Copy link
Contributor

This is not in publish3.

wli3 referenced this issue in wli3/cli Jul 14, 2017
@333fred
Merge pull request #721 from dotnet/fix-download
6cee74c 
Fixed the download scripts to consume cli rel/1.0.0 branch
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jun 7, 2022
@JanKrivanek
Feature/multichoices (dotnet#4732)
d83028f 
* dotnet#4490 implementing support for quote-less choice literals (dotnet#4574)

* dotnet#4490 implementing support for quote-less choice literals

* Testfix

* Make the unquoted literals feature opt-in via EnableQuotelessLiterals property

* Localize error message

* Fix code and tests after merge

* Multichoice implementation contd (dotnet#4666)

* dotnet#4490 implementing support for quote-less choice literals

* dotnet#4490 multichoice parameters implementation

* Add Tab completion test cases

* Fix code + tests after merge

* Fix code and unit tests after merging

* Add support for multichoice parameters in join macro

* Improve based on review comments

* fix dotnet#4650 - adding validation for multichoice symbols (dotnet#4698)

* fix dotnet#4650 - adding validation for multichoice symbols

* Adjust error message

* Multichoice refactor quoteless (dotnet#4708)

* dotnet#4665 Refactoring part 1: Make EnableQuotelessLiterals exposed only to Orchestrator

* Fix parameters localization

* Fix after merge
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jun 21, 2022
@JanKrivanek
Feature/multichoices (dotnet#4732)
a5ab42c 
* dotnet#4490 implementing support for quote-less choice literals (dotnet#4574)

* dotnet#4490 implementing support for quote-less choice literals

* Testfix

* Make the unquoted literals feature opt-in via EnableQuotelessLiterals property

* Localize error message

* Fix code and tests after merge

* Multichoice implementation contd (dotnet#4666)

* dotnet#4490 implementing support for quote-less choice literals

* dotnet#4490 multichoice parameters implementation

* Add Tab completion test cases

* Fix code + tests after merge

* Fix code and unit tests after merging

* Add support for multichoice parameters in join macro

* Improve based on review comments

* fix dotnet#4650 - adding validation for multichoice symbols (dotnet#4698)

* fix dotnet#4650 - adding validation for multichoice symbols

* Adjust error message

* Multichoice refactor quoteless (dotnet#4708)

* dotnet#4665 Refactoring part 1: Make EnableQuotelessLiterals exposed only to Orchestrator

* Fix parameters localization

* Fix after merge
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jul 11, 2022
@JanKrivanek
Feature/multichoices (dotnet#4732)
9103ef9 
* dotnet#4490 implementing support for quote-less choice literals (dotnet#4574)

* dotnet#4490 implementing support for quote-less choice literals

* Testfix

* Make the unquoted literals feature opt-in via EnableQuotelessLiterals property

* Localize error message

* Fix code and tests after merge

* Multichoice implementation contd (dotnet#4666)

* dotnet#4490 implementing support for quote-less choice literals

* dotnet#4490 multichoice parameters implementation

* Add Tab completion test cases

* Fix code + tests after merge

* Fix code and unit tests after merging

* Add support for multichoice parameters in join macro

* Improve based on review comments

* fix dotnet#4650 - adding validation for multichoice symbols (dotnet#4698)

* fix dotnet#4650 - adding validation for multichoice symbols

* Adjust error message

* Multichoice refactor quoteless (dotnet#4708)

* dotnet#4665 Refactoring part 1: Make EnableQuotelessLiterals exposed only to Orchestrator

* Fix parameters localization

* Fix after merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brthor brthor

Labels
Bug
Projects
None yet
Milestone
1.0.0-rtm
Development

No branches or pull requests
4 participants
@livarcocc @TheRealPiotrP @msftgits @brthor