Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Do not create a directory with a trailing space #8587

Merged

Conversation

johnbeisner
Copy link

@johnbeisner johnbeisner commented Feb 10, 2018

Do not create a directory with a trailing space; it cannot be deleted by conventional methods. The directory behaves as if it wasn't there.

We've seen this impact a Windows leg:
https://devdiv.visualstudio.com/DevDiv/Default/_build/index?buildId=1370797
Error in "Get sources" step:
Could not find a part of the path 'E:\A_work\2413\s\bin\3\win81-x86\test\Microsoft.DotNet.ShellShim.Tests\TestAppSimple'

Manual Solution:
In a cmd shell [please notice the trailing space in the directory name]:
rd "\\?\E:\A\_work\2413\s\bin\3\win81-x86\test\Microsoft.DotNet.ShellShim.Tests\TestAppSimple "

@johnbeisner johnbeisner self-assigned this Feb 10, 2018
@johnbeisner johnbeisner requested review from mmitche, dagood and a team February 10, 2018 00:22
@johnbeisner johnbeisner merged commit 82f9d6e into dotnet:release/2.1.3xx Feb 10, 2018
livarcocc added a commit that referenced this pull request Feb 15, 2018
…ease/2.1.3xx-to-master

* dotnet/release/2.1.3xx:
  Update to aspnetcore 2.1.0-preview1-28275 and react to feed layout changes (#8611)
  "ExternalRestoreSources" needs to be set in the docker container (#8602)
  Signing nupkg contents (Cli.Utils and MSBuildResolver) along with the rest of the compiled assemblies.
  Use satellites from roslyn package, not cli-deps-satellites
  Update to roslyn 2.7.0-beta3-62612-07 for 2.1.1xx
  Support TildeSlash expand (#8589)
  Port Kernel Version telemetry to preview1
  Do not create a directory with a trailing space; it cannot be deleted by conventional methods. (#8587)
  Consume generic aspnetcore rpm installers
  Insert NuGet Build 4.6.0-rtm-4918 into cli
  Adding roslyn to automatic dependency flow through maestro.
  Fixing update dependency by using the new APIs. We broke this when we updated the version of VersionTools.
  MSBuild 15.6.81
  Update SDK to 2.1.300-preview1-62608-07
  MSBuild 15.6.80

 Conflicts:
	build/DependencyVersions.props
	test/Microsoft.DotNet.ShellShim.Tests/ShellShimMakerTests.cs
@johnbeisner johnbeisner deleted the UndeletableDirectory branch February 25, 2018 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants