This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
"ExternalRestoreSources" needs to be set in the docker container #8602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
approved these changes
Feb 13, 2018
|
(Aside: I read this variable as ResToResource. 😕) |
livarcocc
approved these changes
Feb 13, 2018
johnbeisner
changed the title
johnbeisner
changed the title
johnbeisner
changed the title
livarcocc
added a commit
that referenced
this pull request
Feb 15, 2018
…ease/2.1.3xx-to-master * dotnet/release/2.1.3xx: Update to aspnetcore 2.1.0-preview1-28275 and react to feed layout changes (#8611) "ExternalRestoreSources" needs to be set in the docker container (#8602) Signing nupkg contents (Cli.Utils and MSBuildResolver) along with the rest of the compiled assemblies. Use satellites from roslyn package, not cli-deps-satellites Update to roslyn 2.7.0-beta3-62612-07 for 2.1.1xx Support TildeSlash expand (#8589) Port Kernel Version telemetry to preview1 Do not create a directory with a trailing space; it cannot be deleted by conventional methods. (#8587) Consume generic aspnetcore rpm installers Insert NuGet Build 4.6.0-rtm-4918 into cli Adding roslyn to automatic dependency flow through maestro. Fixing update dependency by using the new APIs. We broke this when we updated the version of VersionTools. MSBuild 15.6.81 Update SDK to 2.1.300-preview1-62608-07 MSBuild 15.6.80 Conflicts: build/DependencyVersions.props test/Microsoft.DotNet.ShellShim.Tests/ShellShimMakerTests.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up action completed:
ExternalRestoreSources is set as an VSO variable and removed as a property from BuildArguments in AllLinux: https://devdiv.visualstudio.com/DevDiv/Default/_build/index?context=allDefinitions&path=%5CDotNet%5CCLI%5Cmaster&definitionId=7254
The "ExternalRestoreSources" value needs to be set in the internal call to 'build.sh'. Another way to say this is: since 'build.sh' writes a new Nuget.Config for the 'SandBox' working directory; "ExternalRestoreSources" needs to be set in the docker container.
Final fix:
Using an environmental variable to communicate "ExternalRestoreSources" to the docker container.
Follow-up:
Add "ExternalRestoreSources" as a VSO variable to: https://devdiv.visualstudio.com/DevDiv/Default/_build/index?context=allDefinitions&path=%5CDotNet%5CCLI%5Cmaster&definitionId=7254
Testing - with "20180213-02" orchestrated build inputs:
https://devdiv.visualstudio.com/DevDiv/Default/_build/index?buildId=1381420 FAILED
New test build:
https://devdiv.visualstudio.com/DevDiv/Default/_build/index?buildId=1381703 FAILED
Reference: dotnet/msbuild#1622
Passing the 'ExternalRestoreSource's property explictly is not working as msbuild turns the URL into a local path by turning "//" into "/"
Final try:
https://devdiv.visualstudio.com/DevDiv/Default/_build/index?buildId=1382529 SUCCESS