Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet-counters formatting broken in 8.0 #3665

Closed
BrennanConroy opened this issue Feb 16, 2023 · 4 comments · Fixed by #3816
Closed

dotnet-counters formatting broken in 8.0 #3665

BrennanConroy opened this issue Feb 16, 2023 · 4 comments · Fixed by #3816
Assignees
@tommcdon
Labels
bug Something isn't working
Milestone
8.0.0

Comments

@BrennanConroy
Copy link
Member

Description

Running dotnet counters monitor --process-id <id> with runtime version 8.0.0-preview.2.23110.1 results in badly formatted counters.
Output:

Press p to pause, r to resume, q to quit.
    Status: Running

[System.Runtime]
          0             58.151          4.515          0                   0              0              0              0              0              0            113        220,055          3,187              0

I also just tried with the newly released 7.0.411501 version of dotnet-counters, it has the same issue.

Configuration

Using a preview of 8.0 runtime breaks the output formatting of the counters tool.

Regression?

Yes. Works on runtime 7.0.x.

Other information
@BrennanConroy BrennanConroy added the bug Something isn't working label Feb 16, 2023
@hoyosjs hoyosjs added this to the 8.0.0 milestone Feb 21, 2023
@hoyosjs
Copy link
Member

hoyosjs commented Feb 21, 2023

cc: @dramos020

@samsp-msft
Copy link
Member

Example screenshot for the issue:
image

@hoyosjs
Copy link
Member

hoyosjs commented Feb 23, 2023

@samsp-msft I assume that is an app where it works? Is that against .NET 7? And what version of the tool is it against?

@BrennanConroy
Copy link
Member Author

Pretty sure we said that was a different issue. @ReubenBond was seeing that one.

@tommcdon tommcdon mentioned this issue Apr 11, 2023
Merged
@tommcdon tommcdon self-assigned this Apr 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tommcdon tommcdon

Labels
bug Something isn't working
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Fix incorrect rendering of counters tommcdon/diagnostics
4 participants
@BrennanConroy @tommcdon @hoyosjs @samsp-msft