don't traverse excluded folders to avoid PathTooLongException #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -34,9 +34,15 @@ private static IEnumerable<string> GetFilesCore(string cwd, IEnumerable<GlobMatc | |||
|
|
|||
| private static IEnumerable<string> GetFilesFromSubfolder(string baseDirectory, string cwd, IEnumerable<GlobMatcher> globs, IEnumerable<GlobMatcher> excludeGlobs) | |||
| { | |||
| var relativePath = GetRelativeFilePath(cwd, baseDirectory); | |||
There was a problem hiding this comment.
When I wanna exclude node_modules folder? should it be node_modules/ instead of node_modules/**? Consider the following case: exclude: **/node1, while there are folder node1 and file a/node2, folder node1 should not be excluded.
There was a problem hiding this comment.
@vicancy fixed. Now both node_modules/ and node_modules/** can work, and only node_modules/ can be used to avoid PathTooLongException.
|
👍 |
|
committed in 22dcba0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #156
@chenkennt @vicancy @vwxyzh @qinezh