Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet cli Project Tools - prefercliruntime #7292

Closed
amis92 opened this issue Aug 25, 2018 · 14 comments
Closed

dotnet cli Project Tools - prefercliruntime #7292

amis92 opened this issue Aug 25, 2018 · 14 comments
Assignees
Labels
doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri3

Comments

@amis92
Copy link

amis92 commented Aug 25, 2018

There is no documentation for the file prefercliruntime which affects DotNet CLI Project Tools.

I've tried searching for it on the docs webpage: https://docs.microsoft.com/en-us/search/index?search=prefercliruntime

There's no results there, neither are there any in this repo.

I believe it should be a part of this sub-topic: https://docs.microsoft.com/en-us/dotnet/core/tools/extensibility#building-tools

This is currently the most official resource/sample: https://github.com/dotnet/cli/tree/rel/1.0.0/TestAssets/TestPackages/dotnet-prefercliruntime

This topic is also referenced in some depth in these issues:

@mairaw
Copy link
Contributor

mairaw commented Aug 26, 2018

Thanks for letting me know about this @amis92. Somehow I missed the tag last year and no one ever brought the need for docs for that before.

@livarcocc @KathleenDollard we’ll need more info about this and what’s the current state of tools

@mairaw mairaw added 📚 Area - .NET Core Guide waiting-on-feedback Waiting for feedback from SMEs before they can be merged doc-idea Indicates issues that are suggestions for new topics [org][type][category] labels Aug 26, 2018
@amis92
Copy link
Author

amis92 commented Oct 24, 2018

Is this going anywhere?

@amis92
Copy link
Author

amis92 commented Jan 21, 2019

Another quarter. Ping! @livarcocc @KathleenDollard

@mwpowellhtx
Copy link

Whether a "file exists" to signal the CLI seems like a bit of a hack to me? I mean, not even a JSON configuration, for instance?

@amis92
Copy link
Author

amis92 commented May 28, 2019

@mwpowellhtx since the project tools are getting deprecated in favor of Local Tools, I don't think this'll ever get any traction. And Local Tools don't have a problem like that anyway.

@mwpowellhtx
Copy link

@amis92 Well, that's really the bottom line. That, or what's the migration path. What is Local Tools, are there links for that? Thanks.

@amis92
Copy link
Author

amis92 commented May 29, 2019

@KathleenDollard
Copy link
Contributor

Here is text that @wli3 put together:

It is an empty file under the root of “lib” folder of the nupkg with name “prefercliruntime” (case sensitive on Linux). The existence of it indicates the tool prefer to use dotnet SDK’s runtime(to original bundled SDK’s runtime) instead of the runtime it built with (stored in MYTOOL.runtimeconfig.json). However, if SDK’s runtime version is different in major version of runtimeconfig.json’s version. It will be no longer be honored.

@amis92
Copy link
Author

amis92 commented May 29, 2019

I'm pretty sure it's supposed to be just root instead of "lib" folder:

https://github.com/dotnet/cli/blob/24d003f0e06130c951b3594c5a2e7ee06d50a31c/TestAssets/TestPackages/dotnet-prefercliruntime/dotnet-prefercliruntime.csproj

(it's a master branch at the time of writing)

@mwpowellhtx
Copy link

Similar search under Duck about the third result, behind dognet-nuget-locals and global-tools funnily enough, ?q=dotnet%2Blocal%2Btools&ia=web. Thanks... 👍

@wli3
Copy link

wli3 commented May 29, 2019

Sorry, I misread the test here

It should be under the root.

It is an empty file under the root of the nupkg with name “prefercliruntime” (case sensitive on Linux). The existence of it indicates the tool prefer to use dotnet SDK’s runtime(to original bundled SDK’s runtime) instead of the runtime it built with (stored in MYTOOL.runtimeconfig.json). However, if SDK’s runtime version is different in major version of runtimeconfig.json’s version. It will be no longer be honored.

@tdykstra tdykstra removed the waiting-on-feedback Waiting for feedback from SMEs before they can be merged label May 7, 2020
@tdykstra tdykstra self-assigned this Jul 19, 2020
@tdykstra tdykstra added the P2 label Jul 29, 2020
@tdykstra
Copy link
Contributor

@wli3 Does the runtime roll forward functionality make prefercliruntime obsolete, or are there still scenarios that require it?

@tdykstra tdykstra added the waiting-on-feedback Waiting for feedback from SMEs before they can be merged label Dec 18, 2020
@wli3
Copy link

wli3 commented Dec 18, 2020

roll forward functionality applies to dotnet tools, prefercliruntime applies to project tools. And dotnet tools is a replacement for project tools.

@tdykstra tdykstra removed P2 waiting-on-feedback Waiting for feedback from SMEs before they can be merged labels Dec 18, 2020
@tdykstra
Copy link
Contributor

Closing this issue, since project tools are replaced by dotnet tools and prefercliruntime isn't relevant to dotnet tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri3
Projects
None yet
Development

No branches or pull requests

8 participants