Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate tests with with [FrameworkSkipCondition] #10566

Closed
smitpatel opened this issue Dec 14, 2017 · 1 comment
Closed

Investigate tests with with [FrameworkSkipCondition] #10566

smitpatel opened this issue Dec 14, 2017 · 1 comment
Assignees
@bricelam
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
2.1.0

Comments

@smitpatel
Copy link
Contributor

Simply eliminate it. Since with multiple netcoreapp tfm we need different enum.

We have 4 tests disabled by it. (without tracking issue)

One of them is blocked on coreclr issue which is already fixed. Rest 3 no clue.
@ajcvickers ajcvickers mentioned this issue Dec 19, 2017
Closed
@ajcvickers
Copy link
Member

Added a note to #7160

@ajcvickers ajcvickers added this to the 2.1.0 milestone Jan 29, 2018
@ajcvickers ajcvickers reopened this Jan 29, 2018
@bricelam bricelam changed the title Test: Refine FrameworkSkipConditionAttribute Investigate tests with with [FrameworkSkipCondition] Feb 6, 2018
@bricelam bricelam mentioned this issue Feb 6, 2018
Merged
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 6, 2018
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview2, 2.1.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@bricelam @ajcvickers @smitpatel