Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServer Spatial: Add provider-specific functions #13421

Closed
bricelam opened this issue Sep 26, 2018 · 3 comments
Closed

SqlServer Spatial: Add provider-specific functions #13421

bricelam opened this issue Sep 26, 2018 · 3 comments
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-enhancement

Comments

@bricelam
Copy link
Contributor

bricelam commented Sep 26, 2018

We should consider adding (based on feedback) some of SQL Server's spatial methods to EF.Functions.

SQL Method Notes
AsBinaryZM Like new WKBWriter().Write(geometry)
AsGml Like new GMLWriter().Write(geometry)
BufferWithCurves Needs NetTopologySuite/NetTopologySuite#247
BufferWithTolerance Like geometry.Buffer(distance, parameters)
CollectionAggregate Needs #13278
ConvexHullAggregate Needs #13278
CurveToLineWithTolerance Potential workaround for NetTopologySuite/NetTopologySuite#247
EnvelopeAggregate Needs #13278
EnvelopeAngle
EnvelopeCenter
GeomFromGml Like new GMLReader().Read(gml)
HasM Like double.IsNaN(point.M)
HasZ Like double.IsNaN(point.Z)
InstanceOf Like geometry is TGeometry
IsValidDetailed
MakeValid
MinDbCompatibilityLevel Mitigates serialization format changes
Parse Like new WKTReader().Read(text)
Point Optimized version of STPointFromText
Reduce Like simplifiers in NTS
ReorientObject
ShortestLineTo Like DistanceOp.NearestPoints(geometry1, gometry2)
STAsText Like new WKTWriter().Write(geometry)
STCurveN Needs NetTopologySuite/NetTopologySuite#247
STCurveToLine Potential workaround for NetTopologySuite/NetTopologySuite#247
STGeomCollFromText Like new WKTReader().Read(text)
STGeomCollFromWKB Like new WKBReader().Read(binary)
STGeomFromText Like new WKTReader().Read(text)
STGeomFromWKB Like new WKBReader().Read(binary)
STLineFromText Like new WKTReader().Read(text)
STLineFromWKB Like new WKBReader().Read(binary)
STMLineFromText Like new WKTReader().Read(text)
STMLineFromWKB Like new WKBReader().Read(binary)
STMPointFromText Like new WKTReader().Read(text)
STMPointFromWKB Like new WKBReader().Read(binary)
STMPolyFromText Like new WKTReader().Read(text)
STMPolyFromWKB Like new WKBReader().Read(binary)
STNumCurves
STPointFromText Like new WKTReader().Read(text)
STPointFromWKB Like new WKBReader().Read(binary)
STPolyFromText Like new WKTReader().Read(text)
STPolyFromWKB Like new WKBReader().Read(binary)
UnionAggregate Needs #13278
@ajcvickers
Copy link
Member

Note from triage: let's see whether it makes more sense to make a PR to NTS for the curve ones.

@ajcvickers
Copy link
Member

Closing this as we don't intend to proactively implement these. However, this does not mean will will not implement some specific functions based on feedback, and we will likely consider well-written PRs for any of these.

@ajcvickers ajcvickers added closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. and removed propose-close labels Nov 16, 2019
@ajcvickers ajcvickers removed this from the Backlog milestone Nov 16, 2019
@juliusfriedman
Copy link

Just as a FYI NTS Doesn't offer a comparable function for MakeValid and I am not sure if one can use the Microsoft.SqlSerer.Types package on Linux to do it manually either.

@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-enhancement
Projects
None yet
Development

No branches or pull requests

3 participants