Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Bitwise Ex-Or support #16645

Closed
smitpatel opened this issue Jul 17, 2019 · 3 comments · Fixed by #34071
Closed

Query: Bitwise Ex-Or support #16645

smitpatel opened this issue Jul 17, 2019 · 3 comments · Fixed by #34071
Assignees
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@smitpatel
Copy link
Contributor

Currently client eval

@ranma42
Copy link
Contributor

ranma42 commented Jun 23, 2024

related to #18795 (which includes also other bitwise operators)

@cincuranet cincuranet modified the milestones: Backlog, 9.0.0-preview7 Jun 24, 2024
@cincuranet cincuranet added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 24, 2024
@cincuranet cincuranet assigned ranma42 and unassigned roji Jun 24, 2024
@roji
Copy link
Member

roji commented Aug 23, 2024

Interestingly, in PG the caret (^) isn't bitwise XOR, it's exponentiation; hash (#) is used for bitwise XOR. See below for a cross-database list.

@ranma42 given that XOR currently isn't supported in SQLite, can you confirm that we don't have any translations actually relying on that? Since these would fail in SQLite (IIRC you introduced XOR for SQL Server-specific search condition transformations, so seems fine - just confirming).

@ranma42
Copy link
Contributor

ranma42 commented Aug 23, 2024

@ranma42 given that XOR currently isn't supported in SQLite, can you confirm that we don't have any translations actually relying on that? Since these would fail in SQLite (IIRC you introduced XOR for SQL Server-specific search condition transformations, so seems fine - just confirming).

Yes, inside of efcore the XOR is currently only used to avoid some back-and-forth between boolean value and boolean predicate in SqlServer. It would be trivial to support it for boolean values on sqlite, while other values would require plugging something like ef_xor.

@roji roji modified the milestones: 9.0.0-preview7, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants