Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow test seeding data to be intercepted/tweaked by providers #26068

Open
roji opened this issue Sep 16, 2021 · 2 comments
Open

Allow test seeding data to be intercepted/tweaked by providers #26068

roji opened this issue Sep 16, 2021 · 2 comments

Comments

@roji
Copy link
Member

roji commented Sep 16, 2021

As an example, PostgreSQL does not support storing a DateTimeOffset (with non-zero offset). Since test suites such as GearsOfWar and ConferencePlanner contain such data, Npgsql needs to override and modify the data; but seed data currently isn't factored so that this can be done easily.

  • GearsOfWar, JsonQuery, ConferencePlanner
  • ValueConvertersEndToEnd: TestValues
  • BuiltInDataTypes
    • Tests like Can_insert_and_read_back_non_nullable_backed_data_types, Can_query_using_any_data_type_nullable_shadow which only work if all data types are supported exactly as-is.
    • AssertEqualIfMapped is private
    • Review the test suite in general
@lauxjpn
Copy link
Contributor

lauxjpn commented Jan 13, 2022

We hit this one for Pomelo for the EF Core 6.0.1 update as well.

@roji
Copy link
Member Author

roji commented Oct 23, 2023

/cc @maumar this is complicating my life also for JsonQueryNpgsqlTest. Nothing critical, just something to keep in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants