TPC scenario not supported #28015

Luigi6821 · 2022-05-12T12:06:47Z

Hi,
Looking at the new build preview I was playing with TPC to check the following scenario:

`public abstract class AMOS_ADDRESS
{
public decimal ADDRESSID { get; set; }

    public string CODE { get; set; }

    public string ALPHACODE { get; set; }
}

public abstract class AMOS_ADDRESSCONTACT
{
    public decimal ADDRESSCONTACTID { get; set; }

    public AMOS_ADDRESS ADDRESS { get; set; }

    public decimal ADDRESSID { get; set; }
}
#endregion

public class ADDRESS : AMOS_ADDRESS
{ }

public class ADDRESSCONTACT : AMOS_ADDRESSCONTACT
{
}

....
modelBuilder.Entity<AMOS_ADDRESS>().ToTable("ADDRESS", "AMOS");
modelBuilder.Entity<AMOS_ADDRESS>().HasKey(e => e.ADDRESSID);
modelBuilder.Entity<AMOS_ADDRESS>().Property(e => e.CODE).HasColumnName("CODE");
modelBuilder.Entity<AMOS_ADDRESS>().Property(e => e.ALPHACODE).HasColumnName("ALPHACODE");
modelBuilder.Entity<AMOS_ADDRESS>().Property(e => e.ADDRESSID).HasColumnName("ADDRESSID");

modelBuilder.Entity<AMOS_ADDRESSCONTACT>().ToTable("ADDRESSCONTACT");
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().HasKey(e => e.ADDRESSCONTACTID);
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().Property(e => e.ADDRESSCONTACTID).HasColumnName("ADDRESSCONTACTID");
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().Property(e => e.ADDRESSID).HasColumnName("ADDRESSID");
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().HasOne(e => e.ADDRESS);`

The error I receive when I try to run

var o = dbContext.Set<ADDRESS>().OrderBy(a => a.ADDRESSID).Take(10);

is:

The corresponding CLR type for entity type 'AMOS_ADDRESS' cannot be instantiated, and there is no derived entity type in the model that corresponds to a concrete CLR type.

The same code is perfectly supported by EF6.
Is the TPC implementation still not yet completed ?

Regards
Luigi

Originally posted by @Luigi6821 in #3170 (comment)

The text was updated successfully, but these errors were encountered:

AndriySvyryd · 2022-05-13T16:38:15Z

@Luigi6821 Don't call modelBuilder.Entity<AMOS_ADDRESS>().ToTable("ADDRESS", "AMOS"); or modelBuilder.Entity<AMOS_ADDRESSCONTACT>().ToTable("ADDRESSCONTACT");. If the entity type is abstract it means that there should be no rows in the corresponding table. Instead call

modelBuilder.Entity<AMOS_ADDRESS>().UseTpcMappingStrategy();
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().UseTpcMappingStrategy();

modelBuilder.Entity<ADDRESS>().ToTable("ADDRESS", "AMOS");
modelBuilder.Entity<ADDRESSCONTACT>().ToTable("ADDRESSCONTACT");

Also, you can't yet configure a different column name for one of the tables, that's coming in #19811

Luigi6821 · 2022-05-16T09:30:44Z

Hi @AndriySvyryd
This is my model :

    public abstract class AMOS_ADDRESS 
    {
        public decimal ADDRESSID { get; set; }

        public string CODE { get; set; }

        public string ALPHACODE { get; set; }

        public List<AMOS_ADDRESSCONTACT> CONTACTS { get; set; }
    }

    public abstract class AMOS_ADDRESSCONTACT
    {
        public decimal ADDRESSCONTACTID { get; set; }

        public AMOS_ADDRESS ADDRESS { get; set; }

        public decimal ADDRESSID { get; set; }
    }

    public class ADDRESS : AMOS_ADDRESS
    { }

    public class ADDRESSCONTACT : AMOS_ADDRESSCONTACT
    { }
...

I tried configure it in this way:

modelBuilder.Entity<AMOS_ADDRESS>().UseTpcMappingStrategy();
modelBuilder.Entity<ADDRESS>().ToTable("ADDRESS", "AMOS");
modelBuilder.Entity<ADDRESS>().HasKey(e => e.ADDRESSID);
modelBuilder.Entity<ADDRESS>().Property(e => e.ADDRESSID).HasColumnName("ADDRESSID");
modelBuilder.Entity<ADDRESS>().Property(e => e.CODE).HasColumnName("CODE");
modelBuilder.Entity<ADDRESS>().Property(e => e.ALPHACODE).HasColumnName("ALPHACODE");
modelBuilder.Entity<ADDRESS>().Property(e => e.ADDRESSID).HasColumnName("ADDRESSID");
modelBuilder.Entity<ADDRESS>().HasMany(e => e.CONTACTS);

modelBuilder.Entity<AMOS_ADDRESSCONTACT>().UseTpcMappingStrategy();
modelBuilder.Entity<ADDRESSCONTACT>().ToTable("ADDRESSCONTACT");
modelBuilder.Entity<ADDRESSCONTACT>().HasKey(e => e.ADDRESSCONTACTID);
modelBuilder.Entity<ADDRESSCONTACT>().Property(e => e.ADDRESSCONTACTID).HasColumnName("ADDRESSCONTACTID");
modelBuilder.Entity<ADDRESSCONTACT>().Property(e => e.ADDRESSID).HasColumnName("ADDRESSID");
modelBuilder.Entity<ADDRESSCONTACT>().HasOne(e => e.ADDRESS);

But no luck:
The property 'AMOS_ADDRESS.ADDRESSID' could not be mapped because it is of type 'decimal', which is not a supported primitive type or a valid entity type. ...

Please can you help me on how to configure model builder?
Thanks in advance.

Regards
Luigi

AndriySvyryd · 2022-05-16T18:14:42Z

@Luigi6821 What provider are you using? The following configuration might work better:

 modelBuilder.Entity<AMOS_ADDRESS>().UseTpcMappingStrategy();
 modelBuilder.Entity<AMOS_ADDRESS>().HasKey(e => e.ADDRESSID);
 modelBuilder.Entity<AMOS_ADDRESS>().Property(e => e.CODE).HasColumnName("CODE");
 modelBuilder.Entity<AMOS_ADDRESS>().Property(e => e.ALPHACODE).HasColumnName("ALPHACODE");
 modelBuilder.Entity<AMOS_ADDRESS>().Property(e => e.ADDRESSID).HasColumnName("ADDRESSID");
 modelBuilder.Entity<ADDRESS>().ToTable("ADDRESS", "AMOS");

modelBuilder.Entity<AMOS_ADDRESSCONTACT>().UseTpcMappingStrategy();
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().HasKey(e => e.ADDRESSCONTACTID);
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().Property(e => 
    e.ADDRESSCONTACTID).HasColumnName("ADDRESSCONTACTID");
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().Property(e => e.ADDRESSID).HasColumnName("ADDRESSID");
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().HasOne(e => e.ADDRESS);
modelBuilder.Entity<ADDRESSCONTACT>().ToTable("ADDRESSCONTACT");

Luigi6821 · 2022-05-16T22:03:42Z

 modelBuilder.Entity<AMOS_ADDRESS>().UseTpcMappingStrategy();
 modelBuilder.Entity<AMOS_ADDRESS>().HasKey(e => e.ADDRESSID);
 modelBuilder.Entity<AMOS_ADDRESS>().Property(e => e.CODE).HasColumnName("CODE");
 modelBuilder.Entity<AMOS_ADDRESS>().Property(e => e.ALPHACODE).HasColumnName("ALPHACODE");
 modelBuilder.Entity<AMOS_ADDRESS>().Property(e => e.ADDRESSID).HasColumnName("ADDRESSID");
 modelBuilder.Entity<ADDRESS>().ToTable("ADDRESS", "AMOS");

modelBuilder.Entity<AMOS_ADDRESSCONTACT>().UseTpcMappingStrategy();
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().HasKey(e => e.ADDRESSCONTACTID);
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().Property(e => 
    e.ADDRESSCONTACTID).HasColumnName("ADDRESSCONTACTID");
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().Property(e => e.ADDRESSID).HasColumnName("ADDRESSID");
modelBuilder.Entity<AMOS_ADDRESSCONTACT>().HasOne(e => e.ADDRESS);
modelBuilder.Entity<ADDRESSCONTACT>().ToTable("ADDRESSCONTACT");

Hi @AndriySvyryd,
Still same error
[The property 'ADDRESS.ADDRESSID' could not be mapped because it is of type 'decimal', which is not a supported primitive type or a valid entity type. Either explicitly map this property, or ignore it using the '[NotMapped]' attribute or by using 'EntityTypeBuilder.Ignore' in ...]

I'm using SQL Server.

This is the rest of the code:

SqlConnection connection = new SqlConnection()
{
ConnectionString = "User=amos;Password=;Data source=localhost\SQL2019;Initial catalog=ABS10300DEMO"
};

var optionsBuilder = new DbContextOptionsBuilder();
var model = modelBuilder.FinalizeModel();
optionsBuilder.UseModel(model);

connection.Open();

optionsBuilder.UseSqlServer(connection);
using (var dbContext = new DbContext(optionsBuilder.Options))
{
// ===> Here error
var addresses = dbContext.Set

().OrderBy(a => a.ADDRESSID).Take(10);
....

Any suggestions?

Thanks
Luigi

AndriySvyryd · 2022-05-16T22:45:39Z

How do you create the ModelBuilder? Why don't you use a derived DbContext instead?

Luigi6821 · 2022-05-17T07:53:04Z

How do you create the ModelBuilder? Why don't you use a derived DbContext instead?

The code I submitted is a simplification of a company software where the model is created using this approach which should be perfectly valid.

Anyway module builder is simple instantiated :

var modelBuilder = new ModelBuilder();

I tried using OnModelCreating and it works.

Please can you give me solution using my approach?
Thanks in advance

Regards
Luigi

AndriySvyryd · 2022-05-17T17:20:47Z

Please provide a small self-contained repro project

Luigi6821 · 2022-05-17T20:02:46Z

Please provide a small self-contained repro project

Here you go.
EFcoreTPC.zip

AndriySvyryd · 2022-05-17T22:15:46Z

Targeting SqlServer and using OnModelCreating works:

EFcoreTPC.zip

If you need to call UseModel then use SqlServerConventionSetBuilder.CreateModelBuilder() to create the ModelBuilder

Luigi6821 · 2022-05-18T11:54:54Z

@AndriySvyryd,

I tried using SqlServerConventionSetBuilder... and made some progress but still an error.
I paste here the code I am using:

        var modelBuilder = SqlServerConventionSetBuilder.CreateModelBuilder();//new ModelBuilder();
        modelBuilder.HasDefaultSchema("AMOS");

        modelBuilder.Entity<AMOS_ADDRESS>().UseTpcMappingStrategy();
        modelBuilder.Entity<AMOS_ADDRESS>().HasKey(e => e.ADDRESSID);
        modelBuilder.Entity<AMOS_ADDRESS>().Property(e => e.CODE).HasColumnName("CODE");
        modelBuilder.Entity<AMOS_ADDRESS>().Property(e => e.ALPHACODE).HasColumnName("ALPHACODE");
        modelBuilder.Entity<AMOS_ADDRESS>().Property(e => e.ADDRESSID).HasColumnName("ADDRESSID");
        modelBuilder.Entity<ADDRESS>().HasMany(e => e.CONTACTS);
        modelBuilder.Entity<ADDRESS>().ToTable("ADDRESS", "AMOS");

        modelBuilder.Entity<AMOS_ADDRESSCONTACT>().UseTpcMappingStrategy();
        modelBuilder.Entity<AMOS_ADDRESSCONTACT>().HasKey(e => e.ADDRESSCONTACTID);
        modelBuilder.Entity<AMOS_ADDRESSCONTACT>().Property(e => e.ADDRESSCONTACTID).HasColumnName("ADDRESSCONTACTID");
        modelBuilder.Entity<AMOS_ADDRESSCONTACT>().Property(e => e.ADDRESSID).HasColumnName("ADDRESSID");
        modelBuilder.Entity<AMOS_ADDRESSCONTACT>().HasOne(e => e.ADDRESS);
        modelBuilder.Entity<ADDRESSCONTACT>().ToTable("ADDRESSCONTACT");

        SqlConnection connection = new SqlConnection()
        {
            ConnectionString = "User=amos;Password=<pwd>;Data source=localhost\\SQL2019;Initial catalog=ABS10300DEMO"
        };

        var optionsBuilder = new DbContextOptionsBuilder();
        var model = modelBuilder.FinalizeModel();
        optionsBuilder.UseModel(model);

        connection.Open();

        optionsBuilder.UseSqlServer(connection);
        using (var dbContext = new DerivedDbContext(optionsBuilder.Options))
        {
            var addresses = dbContext.Set<AMOS_ADDRESS>();

=====> Error : System.InvalidOperationException: 'Sequence contains no matching element'
var aAddresses = addresses.ToArray();
=====<
}

Of course AMOS.ADDRESS and AMOS.ADDRESSCONTACT contain rows.
What I am doing wrong?

AndriySvyryd · 2022-05-18T16:44:25Z

@Luigi6821 You can debug SQL queries either by profiling in SSMS, calling addresses.ToQueryString() or by examining addresses.DebugView in the debugger

Luigi6821 · 2022-05-18T17:03:11Z

addresses.ToQueryString()

As per attached image the addresses.ToQueryString() raise same error.. Sequence contains no matching element

AndriySvyryd · 2022-05-18T17:05:39Z

Please provide the stack trace as well

Luigi6821 · 2022-05-18T17:09:39Z

Here below stack trace.
=========>
at System.Linq.ThrowHelper.ThrowNoMatchException()
at Microsoft.EntityFrameworkCore.Query.SqlExpressions.SelectExpression..ctor(IEntityType entityType, ISqlExpressionFactory sqlExpressionFactory)
at Microsoft.EntityFrameworkCore.Query.SqlExpressionFactory.Select(IEntityType entityType)
at Microsoft.EntityFrameworkCore.Query.RelationalQueryableMethodTranslatingExpressionVisitor.CreateShapedQueryExpression(IEntityType entityType)
at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.VisitExtension(Expression extensionExpression)
at Microsoft.EntityFrameworkCore.Query.RelationalQueryableMethodTranslatingExpressionVisitor.VisitExtension(Expression extensionExpression)
at Microsoft.EntityFrameworkCore.SqlServer.Query.Internal.SqlServerQueryableMethodTranslatingExpressionVisitor.VisitExtension(Expression extensionExpression)
at System.Linq.Expressions.Expression.Accept(ExpressionVisitor visitor)
at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
at Microsoft.EntityFrameworkCore.Query.QueryCompilationContext.CreateQueryExecutor[TResult](Expression query)
at Microsoft.EntityFrameworkCore.Storage.Database.CompileQuery[TResult](Expression query, Boolean async)
at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.CompileQueryCore[TResult](IDatabase database, Expression query, IModel model, Boolean async)
at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.<>c__DisplayClass9_01.<Execute>b__0() at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryCache.GetOrAddQuery[TResult](Object cacheKey, Func1 compiler)
at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.Execute[TResult](Expression query)
at Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryProvider.Execute[TResult](Expression expression)
at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ToQueryString(IQueryable source)
at EFCore.TestEFCore.Run() in C:\Users\luigi.esposito\source\repos\ConsoleApp5\EFCore\TestEF.cs:line 46
at ConsoleApp5.Program.Main(String[] args) in C:\Users\luigi.esposito\source\repos\ConsoleApp5\ConsoleApp5\Program.cs:line 11
=============<

AndriySvyryd · 2022-05-18T18:50:10Z

@smitpatel

smitpatel · 2022-05-18T19:14:58Z

TPC is in nightly builds. It is not available in preview4

Luigi6821 · 2022-05-19T12:03:15Z

TPC is in nightly builds. It is not available in preview4

@AndriySvyryd ,
Do I have to wait for preview 5 for this fix?

Regards
Luigi

AndriySvyryd · 2022-05-19T16:34:13Z

You can use daily builds

AndriySvyryd closed this as completed May 13, 2022

AndriySvyryd added closed-no-further-action The issue is closed and no further action is planned. customer-reported labels May 13, 2022

AndriySvyryd removed the closed-no-further-action The issue is closed and no further action is planned. label May 18, 2022

AndriySvyryd reopened this May 18, 2022

smitpatel closed this as completed May 18, 2022

AndriySvyryd added the closed-no-further-action The issue is closed and no further action is planned. label May 18, 2022

ajcvickers reopened this Oct 16, 2022

ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TPC scenario not supported #28015

TPC scenario not supported #28015

Luigi6821 commented May 12, 2022

AndriySvyryd commented May 13, 2022

Luigi6821 commented May 16, 2022 •

edited by AndriySvyryd

Loading

AndriySvyryd commented May 16, 2022

Luigi6821 commented May 16, 2022 •

edited

Loading

AndriySvyryd commented May 16, 2022

Luigi6821 commented May 17, 2022 •

edited

Loading

AndriySvyryd commented May 17, 2022

Luigi6821 commented May 17, 2022

AndriySvyryd commented May 17, 2022 •

edited

Loading

Luigi6821 commented May 18, 2022 •

edited

Loading

AndriySvyryd commented May 18, 2022

Luigi6821 commented May 18, 2022

AndriySvyryd commented May 18, 2022

Luigi6821 commented May 18, 2022

AndriySvyryd commented May 18, 2022

smitpatel commented May 18, 2022

Luigi6821 commented May 19, 2022

AndriySvyryd commented May 19, 2022

TPC scenario not supported #28015

TPC scenario not supported #28015

Comments

Luigi6821 commented May 12, 2022

AndriySvyryd commented May 13, 2022

Luigi6821 commented May 16, 2022 • edited by AndriySvyryd Loading

AndriySvyryd commented May 16, 2022

Luigi6821 commented May 16, 2022 • edited Loading

AndriySvyryd commented May 16, 2022

Luigi6821 commented May 17, 2022 • edited Loading

AndriySvyryd commented May 17, 2022

Luigi6821 commented May 17, 2022

AndriySvyryd commented May 17, 2022 • edited Loading

Luigi6821 commented May 18, 2022 • edited Loading

AndriySvyryd commented May 18, 2022

Luigi6821 commented May 18, 2022

AndriySvyryd commented May 18, 2022

Luigi6821 commented May 18, 2022

AndriySvyryd commented May 18, 2022

smitpatel commented May 18, 2022

Luigi6821 commented May 19, 2022

AndriySvyryd commented May 19, 2022

Luigi6821 commented May 16, 2022 •

edited by AndriySvyryd

Loading

Luigi6821 commented May 16, 2022 •

edited

Loading

Luigi6821 commented May 17, 2022 •

edited

Loading

AndriySvyryd commented May 17, 2022 •

edited

Loading

Luigi6821 commented May 18, 2022 •

edited

Loading