Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Join Elimination/Consolidation #3419

Closed
rowanmiller opened this issue Oct 13, 2015 · 5 comments
Closed

Query: Join Elimination/Consolidation #3419

rowanmiller opened this issue Oct 13, 2015 · 5 comments
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-enhancement

Comments

@rowanmiller
Copy link
Contributor

We often join to the same table(s) multiple times, we should look at adding logic to consolidate these joins. One example is using the same nav prop in an Include and a Where call.

@anpete
Copy link
Contributor

anpete commented Oct 13, 2015

We should only gen a single join per nav prop in the multiple includes case.

@rowanmiller
Copy link
Contributor Author

Cool, nice - I updated the description

@smitpatel
Copy link
Contributor

ping @anpete

@smitpatel
Copy link
Contributor

We don't join to same table multiple times except

  • Asked by user explicitly by including multiple query roots
  • Navigation was expanded and later condensed because of certain terminating operator like Distinct.
  • Table splitting case

@smitpatel
Copy link
Contributor

Closing as pending task is being tracked at #18869

@smitpatel smitpatel removed this from the Backlog milestone Nov 12, 2019
@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Mar 10, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-enhancement
Projects
None yet
Development

No branches or pull requests

4 participants