Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reflection object equality comparisons. #7591

Closed
anpete opened this issue Feb 10, 2017 · 4 comments
Closed

Fix reflection object equality comparisons. #7591

anpete opened this issue Feb 10, 2017 · 4 comments
Assignees
@anpete @divega
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
1.1.1

Comments

@anpete
Copy link
Contributor

anpete commented Feb 10, 2017

Using '==' to compare reflection objects can fail on some platforms that haven't implemented the operator. I.e. .NET Native.
@rowanmiller rowanmiller added this to the 1.1.1 milestone Feb 13, 2017
@anpete
Copy link
Contributor Author

anpete commented Feb 13, 2017

Risk: Very low, moving from '==' to calling the Equals method for reflection object comparisons is essentially a no-op on most platforms because the operator simply delegates to the method anyway.
Impact: High on .NET Native. Enables EF's internal caches to operate correctly on .NET Native.

@maumar maumar closed this as completed in d6a3865 Feb 13, 2017
@divega
Copy link
Contributor

divega commented Feb 15, 2017

Reopening to go through approval process.

@divega divega reopened this Feb 15, 2017
@Eilon
Copy link
Member

Eilon commented Feb 15, 2017

This patch bug is approved. Please use the normal code review process w/ a PR and make sure the fix is in the correct branch, then close the bug and mark it as done.

@anpete anpete closed this as completed Feb 16, 2017
@divega divega added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 16, 2017
@AndriySvyryd
Copy link
Member

✅ Verified

@smitpatel smitpatel mentioned this issue Jul 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anpete anpete

@divega divega

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
5 participants
@Eilon @anpete @divega @rowanmiller @AndriySvyryd