Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Test netcoreapp/netstandard1.x and 2.0 projects #8280

Closed
bricelam opened this issue Apr 25, 2017 · 5 comments
Closed

Tools: Test netcoreapp/netstandard1.x and 2.0 projects #8280

bricelam opened this issue Apr 25, 2017 · 5 comments
Assignees
@bricelam
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.0.0

Comments

@bricelam
Copy link
Contributor

bricelam commented Apr 25, 2017 •
edited
Loading

Will EFCore.Tools 2.0 work on netstandard1.x and netcoreapp1.x projects?

If the startup project is netcoreapp2.0 or net461: Yes.
If not: I don't know.

We need to decided what is supported and engineer a solution to support that. This needs to be done for 2.0.0-preview1.
@bricelam bricelam self-assigned this Apr 25, 2017
@bricelam
Copy link
Contributor Author

bricelam commented Apr 25, 2017 •
edited
Loading

Blocked since netcoreapp2.0 tools don't even work yet. (NuGet/Home#4396)

@bricelam bricelam mentioned this issue Apr 25, 2017
Merged
@bricelam
Copy link
Contributor Author

We also need to test netcoreapp2.0 projects when we can.

@bricelam bricelam added this to the 2.0.0-preview1 milestone Apr 25, 2017
@bricelam bricelam removed the tools label Apr 26, 2017
@bricelam
Copy link
Contributor Author

Discussed yesterday and it should work with all frameworks if you're using the 2.0 SDK.

@bricelam bricelam changed the title Tools: Will EFCore.Tools 2.0 work on netstandard1.x and netcoreapp1.x projects? Tools: Ensure both netcoreapp1.x and 2.0 projects work Apr 27, 2017
@bricelam
Copy link
Contributor Author

Should be unblocked by the next CLI build.

@bricelam bricelam removed the blocked label Apr 28, 2017
@bricelam
Copy link
Contributor Author

bricelam commented May 1, 2017

Tested. Everything looks good. Just one issue with netstandard2.0 class library projects: #8344

@bricelam bricelam closed this as completed May 1, 2017
@bricelam bricelam changed the title Tools: Ensure both netcoreapp1.x and 2.0 projects work Tools: Test netcoreapp/netstandard1.x and 2.0 projects May 1, 2017
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 1, 2017
@ajcvickers ajcvickers modified the milestones: 2.0.0-preview1, 2.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@bricelam @divega @ajcvickers