Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftover references to R9 in repository #4115

Closed
martincostello opened this issue Jun 24, 2023 · 9 comments · Fixed by #4290
Closed

Leftover references to R9 in repository #4115

martincostello opened this issue Jun 24, 2023 · 9 comments · Fixed by #4290

Comments

@martincostello
Copy link
Member

Description

The repo contains various references to the internal R9 project. At least some of these should be removed so that the open source repository is friendly to non-Microsoft contributors who are not familiar with that that is or what it means.

Here are all the references GitHub code search finds: r9 results

I noticed this because the issue template contains this:

image

Reproduction Steps

N/A

Expected behavior

Correct terminology is used.

Actual behavior

Internal code name is used.

Regression?

N/A

Known Workarounds

N/A

Configuration

N/A

Other information

No response

@danmoseley
Copy link
Member

Thanks, yes much of this code came from an internal repo with that name. We should replace them with generic terms.

@danmoseley
Copy link
Member

@RussKie @geeknoid some of these look like DI keys, event sources, counter names -- presumably fixed once shipped. Do we plan to ship these with R9 in the name? Can we avoid any R9 hits in the repo when we ship?

@geeknoid
Copy link
Member

Yes, these are all telemetry things which Nikita will be taking care of soon.

@xakep139
Copy link
Contributor

Yes, these are all telemetry things which Nikita will be taking care of soon.

Hopefully not only me 😀

@RussKie
Copy link
Member

RussKie commented Aug 11, 2023

@xakep139 assigning to you for now. We all be cheering for you :)

@danmoseley
Copy link
Member

Do we need to mark this somehow as "blocking release"/"necessary for GA"

@xakep139
Copy link
Contributor

@xakep139 assigning to you for now. We all be cheering for you :)

I addressed some of these references in #4290

@ghost ghost removed the work in progress 🚧 label Aug 15, 2023
@geeknoid geeknoid reopened this Aug 15, 2023
@geeknoid
Copy link
Member

Still more references remain, so let's keep this open.

@xakep139
Copy link
Contributor

xakep139 commented Oct 23, 2023

@geeknoid, I think this one can be actually closed once #4482 is merged and #4554 is unblocked

@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants