Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to add additional tests to Logging generator #5436

Open
dariusclay opened this issue Sep 20, 2024 · 0 comments
Open

Follow up to add additional tests to Logging generator #5436

dariusclay opened this issue Sep 20, 2024 · 0 comments
Labels

Comments

@dariusclay
Copy link
Contributor

dariusclay commented Sep 20, 2024

@dariusclay / @RussKie - I've backed out the changed to the public API and added some more tests. CI is now green. Let me know once you've reviewed.

I won't get to it, but I also recommend (either as a prereq for this to merge) or as a followup:

  • Adding a test directly against the Type of each value in state.TagArray. We're incidentally testing it with my test additions, but a more targeted test would be ideal.
  • Adding tests directly for TypeSymbolExtensions.{ImplementsIConvertible,ImplementsIFormattable,ImplementsISpanFormattable and the newly introduced helper, TypeSymbolExtensions.GetPossiblyNullWrappedType. This is incidentally being tested with my test additions, but not directly.

Thanks!

Originally posted by @rwoll in #5416 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant