Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to remove RazorCompiler dependency when upgrading to Roslyn 4.10.0 #2075

Closed
mthalman opened this issue Jan 19, 2024 · 2 comments
Closed
Labels
Resolved-Fixed This issue has been fixed

Comments

@mthalman
Copy link
Member

Roslyn deleted the Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler package in dotnet/roslyn#71579. But format still has references to it that need to be removed:

<PackageVersion Include="Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler" Version="$(MicrosoftCodeAnalysisVersion)" />

<PackageReference Include="Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler" ExcludeAssets="compile" />

This currently isn't broken because format still has a dependency on Roslyn 4.9.0; the deletion is in 4.10.0

@sharwell
Copy link
Member

This seems like an automatic maintenance task that will occur during a dependency update. Is there a reason why we need to track it separately? It seems like even once this issue is fixed, it will likely remain open as the author of the pull request to update dependencies wouldn't be aware of its existence.

@mthalman
Copy link
Member Author

This was logged because it required a patch in the installer repo to get source build working since it uses the latest version of Roslyn in source build. When creating a patch, we need to reference an existing issue or PR to track the work so that it ensures the underlying issue gets resolved. Anyway, this has been fixed and the patch was removed in dotnet/installer#18641. Closing.

@sharwell sharwell added the Resolved-Fixed This issue has been fixed label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolved-Fixed This issue has been fixed
Projects
None yet
Development

No branches or pull requests

2 participants