Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In some cases, "Add missing equals" code fix breaks code even further #15547

Closed
Tracked by #15408
psfinaki opened this issue Jul 4, 2023 · 0 comments · Fixed by #15551
Closed
Tracked by #15408

In some cases, "Add missing equals" code fix breaks code even further #15547

psfinaki opened this issue Jul 4, 2023 · 0 comments · Fixed by #15551
Assignees
@psfinaki
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone
Backlog

Comments

@psfinaki
Copy link
Member

psfinaki commented Jul 4, 2023

bug.mp4

This code:

type IA<'b> = 
    abstract Foo : int -> int

type = IB<'b> = 
    inherit IA<'b>
    inherit IA<int>

This is quite an odd scenario for this diag, I guess we just shouldn't trigger it there.
@github-actions github-actions bot added this to the Backlog milestone Jul 4, 2023
@psfinaki psfinaki added the Area-LangService-CodeFixes Code fixes associated with diagnostics label Jul 4, 2023
This was referenced Jul 4, 2023
Open
Merged
@0101 0101 added Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. and removed Needs-Triage labels Jul 10, 2023
@psfinaki psfinaki self-assigned this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psfinaki psfinaki

Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
F# Compiler and Tooling
Archived in project
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fixing code fixes, part 4 psfinaki/fsharp
2 participants
@0101 @psfinaki