Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find All References returns nothing for None in VFT solution #3372

Closed
vasily-kirichenko opened this issue Jul 24, 2017 · 3 comments
Closed

Find All References returns nothing for None in VFT solution #3372

vasily-kirichenko opened this issue Jul 24, 2017 · 3 comments
Labels
Area-LangService-API Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone
16.8

Comments

@vasily-kirichenko
Copy link
Contributor

Execute "Find all references" on None symbol anywhere in FSharp.Compiler.Private project:

image
@dsyme dsyme added Bug Area-LangService-API Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. labels Jul 25, 2017
@vasily-kirichenko
Copy link
Contributor Author

#3387 has not fixed this bug.

@KevinRansom
Copy link
Member

@dsyme Just revert the change then mate, sorry.

@cartermp cartermp reopened this Jan 28, 2018
@cartermp cartermp added this to the 16.0 milestone Aug 29, 2018
@cartermp cartermp modified the milestones: 16.0, 16.1 Feb 21, 2019
@cartermp cartermp modified the milestones: 16.1, 16.2 Apr 23, 2019
@cartermp cartermp modified the milestones: 16.2, Backlog Apr 30, 2019
@cartermp cartermp mentioned this issue Mar 28, 2020
Closed
@cartermp
Copy link
Contributor

This no longer reproduces:

image

However, the navigation often takes you to a garbage location, e.g. the first item in this list takes you to some random union case in a type definition. Still a bug here, just not the one that's reported.

@cartermp cartermp modified the milestones: Backlog, 16.8 Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-LangService-API Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
None yet
Milestone
16.8
Development

No branches or pull requests
4 participants
@vasily-kirichenko @KevinRansom @cartermp @dsyme