Add FSharp.Core package reference with IsImplicitlyDefined = true

[Alxandr]

I just wrote a tool that extracts ProjectReference entries from a msbuild project. It removes any references that is automatically added by the framework by checking for metadata IsImplicitlyDefined. This works for C# and VB, but F# does not add this metadata.

Also, looking at this it seems the same is true for System.ValueTuple.

Repro steps

Create a fsharp SDK based project (for instance dotnet new classlib --language F#). Extract all ProjectReferences.

Expected behavior

FSharp.Core should be added with metadata IsImplicitlyDefined equal to true.

Actual behavior

FSharp.Core is not added with IsImplicitlyDefined.

Known workarounds

Manually add it, which defeats the purpose altogether.

Related information

.NET Command Line Tools (2.0.0)

Product Information:
 Version:            2.0.0
 Commit SHA-1 hash:  cdcd1928c9

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.12
 OS Platform: Darwin
 RID:         osx.10.12-x64
 Base Path:   /usr/local/share/dotnet/sdk/2.0.0/

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.0
  Build    : e8b8861ac7faf042c87a5c2f9f2d04c98b69f28d

[dsyme]

@KevinRansom Could you take a look at this please?

[0x53A]

It looks like this would also solve other issues - according to this comment, PackageReferences without IsImplicitlyDefined take precedence over ones with it. So this would fix the issue where it is impossible to override the implicit FSharp.Core later, which was an issue in Paket.

[dsyme]

@KevinRansom did you take a look at this?

[jeffkl]

I'd like to send a PR to fix this, may I submit it?

https://github.com/microsoft/visualfsharp/compare/master...jeffkl:fix?expand=1

[cartermp]

@jeffkl absolutely!

[cartermp]

Closing out as per the resolution of #6730

[knocte]

Closing out as per the resolution of #6730

So then F# will never be compatible with Central Package Management (Nuget new feature)? See NuGet/Home#11949 (comment)

[cartermp]

Things can always change, and you can always just use paket