Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused value analysis on unused this value can suggest uncompilable code #5419

Closed
Tracked by #15408
cartermp opened this issue Jul 29, 2018 · 1 comment · Fixed by #15663
Closed
Tracked by #15408

Unused value analysis on unused this value can suggest uncompilable code #5419

cartermp opened this issue Jul 29, 2018 · 1 comment · Fixed by #15663
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug good first issue Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Milestone
Backlog

Comments

@cartermp
Copy link
Contributor

Given the following:

type C() as this = class end

this will be marked as an unused value:

screen shot 2018-07-29 at 09 55 50

But the second option will result in code that will not compile:

screen shot 2018-07-29 at 09 56 23
@cartermp cartermp added this to the 16.0 milestone Jul 29, 2018
@cartermp cartermp modified the milestones: 16.0, 16.1 Feb 21, 2019
@cartermp cartermp modified the milestones: 16.1, 16.2 Apr 23, 2019
@cartermp cartermp modified the milestones: 16.2, Backlog Apr 30, 2019
@dsyme dsyme added the Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. label Aug 26, 2020
@dsyme dsyme added Area-LangService-CodeFixes Code fixes associated with diagnostics and removed Area-LangService-API labels Apr 5, 2022
@psfinaki psfinaki mentioned this issue Jun 15, 2023
Open
85 tasks
@psfinaki psfinaki mentioned this issue Jul 19, 2023
Closed
@psfinaki
Copy link
Member

Also partially blocked by #15636 - hard to test

@psfinaki psfinaki mentioned this issue Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug good first issue Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Projects
F# Compiler and Tooling
Archived in project
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fixing code fixes, part 5 psfinaki/fsharp
3 participants
@psfinaki @cartermp @dsyme