Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace specially recognized attributes with dataflow annotations #1349

Open
marek-safar opened this issue Jul 13, 2020 · 2 comments
Open

Replace specially recognized attributes with dataflow annotations #1349

marek-safar opened this issue Jul 13, 2020 · 2 comments

Comments

@marek-safar
Copy link
Contributor

marek-safar commented Jul 13, 2020

In ILLink build, we could replace some of the specially recognized attributes with dataflow annotations attributes and remove the logic from IL linker.

Potential candidates

There are more special attributes recognized by linker but they cannot be expressed with correct annotation or use domain-specific syntax.

@eerhardt @vitek-karas

@MichalStrehovsky
Copy link
Member

The EventSource specific handling will probably end up in the same category.

We'll need to think about the ".NET 6 SDK is used to build a .NET 5 targeting project (that doesn't have the annotations in the corelib)" scenario though.

@marek-safar
Copy link
Contributor Author

We have versioning infrastructure for that already in linker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants