Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] New Navigation Bar to Mimic win ui Behavour In Shell #7345

Open
davidbuckleyni opened this issue May 19, 2022 · 4 comments
Labels
Milestone

Comments

@davidbuckleyni
Copy link

davidbuckleyni commented May 19, 2022

Description

Win Ui navigation as per the win ui gallery app sample shows a left-hand navigation menu that allows child items, it shows that there are child items underneath by allowing a graphic to represent open and close.

image

As you can see the navigation menu item has a root node and the ability for child nodes. The child nodes should allow the ability to have an icon and text and then the link itself which would be another page.

Also the controls should allow animations of opening and closing a section as per WIn UI Gallery sample app found at this repo

https://github.com/microsoft/WinUI-Gallery

It could well be this should be a control separate to shell

Public API Changes

I suggest that we should have a tag under the shell content called subitem or child item

<NavigationBar x:Name="navBar1" DocPosition="Left,Right">
    <ShellContent
        Title="Home"
        ContentTemplate="{DataTemplate local:MainPage}"
        Route="MainPage" />
    <FlyoutItem Title="Basic Input">
        <ShellContent
            Title="Basic Input"
            ContentTemplate="{DataTemplate local:SalesOrderPage}"
            Route="BasicInput" >
           <ChildItem x:Name="mnuInputVal" Text="Input Validations" Icon="" IconPosition="" />
           <ChildItem x:Name="mnubutton" Text="Button" Icon="" IconPosition="" />
            <ChildItem x:Name="mnuDropDownButton" Text="DropDownButton" Icon="" 
             IconPosition="" />    
         </ShellContent>
    </FlyoutItem>
</NavigationBar>

Intended Use-Case

I believe that if Win ui is to be fully supported route then we need to have child items to behave in the same manor as win ui desktop currently does. I only believe this should be one level deep and for us not to get into the same mess of web menus and allow unlimited levels of menus.

@davidbuckleyni davidbuckleyni changed the title New Navigation Bar to Mimic win ui Behavour In Shell [Feature Request] New Navigation Bar to Mimic win ui Behavour In Shell May 19, 2022
@Eilon Eilon added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label May 20, 2022
@PureWeen PureWeen added this to the Backlog milestone Sep 24, 2022
@ghost
Copy link

ghost commented Sep 24, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@PureWeen
Copy link
Member

The ShellHandler's platformview is a NavigationView so if you want to set that menu you can for now.

@jingliancui
Copy link
Contributor

Hope this feature can be implemented, it is important on pc with win and maccatalyst

@eduardoagr
Copy link

I was able to implement something like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants