From 1f309ba2b436c325635e4150f60a8ea21c0984b1 Mon Sep 17 00:00:00 2001 From: Tim Miller Date: Mon, 29 Jan 2024 17:23:37 +0900 Subject: [PATCH 1/2] Add comments to internal methods for XAML Hot Reload usage --- src/Controls/src/Core/IProvideParentValues.cs | 3 +++ src/Controls/src/Core/IValueConverterProvider.cs | 2 ++ src/Core/src/Platform/Standard/ViewExtensions.cs | 2 ++ 3 files changed, 7 insertions(+) diff --git a/src/Controls/src/Core/IProvideParentValues.cs b/src/Controls/src/Core/IProvideParentValues.cs index aa6529a0f37c..32981fba6051 100644 --- a/src/Controls/src/Core/IProvideParentValues.cs +++ b/src/Controls/src/Core/IProvideParentValues.cs @@ -3,8 +3,11 @@ namespace Microsoft.Maui.Controls.Xaml { + // Used by MAUI XAML Hot Reload. + // Consult XET if updating! internal interface IProvideParentValues : IProvideValueTarget { + IEnumerable ParentObjects { get; } } } \ No newline at end of file diff --git a/src/Controls/src/Core/IValueConverterProvider.cs b/src/Controls/src/Core/IValueConverterProvider.cs index 67a77a124d23..32f042e2125c 100644 --- a/src/Controls/src/Core/IValueConverterProvider.cs +++ b/src/Controls/src/Core/IValueConverterProvider.cs @@ -4,6 +4,8 @@ namespace Microsoft.Maui.Controls.Xaml { + // Used by MAUI XAML Hot Reload. + // Consult XET if updating! interface IValueConverterProvider { object Convert(object value, Type toType, Func minfoRetriever, IServiceProvider serviceProvider); diff --git a/src/Core/src/Platform/Standard/ViewExtensions.cs b/src/Core/src/Platform/Standard/ViewExtensions.cs index 265616de7564..40f0680c2c29 100644 --- a/src/Core/src/Platform/Standard/ViewExtensions.cs +++ b/src/Core/src/Platform/Standard/ViewExtensions.cs @@ -69,6 +69,8 @@ public static void UpdateMaximumWidth(this object platformView, IView view) { } internal static System.Numerics.Matrix4x4 GetViewTransform(this IView view) => new System.Numerics.Matrix4x4(); + // Used by MAUI XAML Hot Reload. + // Consult XET if updating! internal static Graphics.Rect GetBoundingBox(this IView view) => view.Frame; internal static object? GetParent(this object? view) From 582525caf0b235d27233ab37f775d732238704db Mon Sep 17 00:00:00 2001 From: Tim Miller Date: Mon, 29 Jan 2024 17:24:11 +0900 Subject: [PATCH 2/2] spacing --- src/Controls/src/Core/IProvideParentValues.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Controls/src/Core/IProvideParentValues.cs b/src/Controls/src/Core/IProvideParentValues.cs index 32981fba6051..665699deaba8 100644 --- a/src/Controls/src/Core/IProvideParentValues.cs +++ b/src/Controls/src/Core/IProvideParentValues.cs @@ -7,7 +7,6 @@ namespace Microsoft.Maui.Controls.Xaml // Consult XET if updating! internal interface IProvideParentValues : IProvideValueTarget { - IEnumerable ParentObjects { get; } } } \ No newline at end of file