Backport Coversion deprecation message to older VS branches/versions

[JanKrivanek]

Motivation

In order to be able to remove Deprecated code in release branches - we'd need to announce the plan for some time via the dialog in the said VS versions - hence this work

Having a usage data would be helpful as well for justifying the removal.

This might be needed as we might need to soon perform more compliancy investments in non-main release branches - and being able to get rid of Deprecated code in thos branches there would then be very beneficial.

Objectives

We want to backport https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/573846 to older (in-support) 17.* VS branches, and older VS versions (16, 15).

We want to as well backport the instrumentation change - https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/552729 - to observe the usages of the feature

Note (10/15/2024): We need as well https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/563147 in order to properly collect the telemetry

Goals

• Backport the PRs to 15.9, 16.11, 17.8 and 17.10 (17.6 to be skipped) - Kitten work
• Backport the https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/552729 PR into same branches
• Prepare QB bugs (template https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/1969/Bug-Template-for-M2-and-QB-Modes?anchor=vs-ask-mode-template) for each of the backports (to be handled by @JanKrivanek)
• Get the team, division and QB approval (to be handled by @JanKrivanek)

Timeline

let's target Nov patching Tuesday - so deadline around Oct/31st (https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/27212/Dev15-16-17-Servicing-Schedule)

Telemetry query

Telemetry query to check the feature usage:

RawEventsVS
| take 1000000
| where EventName == "Vs/Vsproject/Xmlparser/XMakeHelper/IsProjectFileInOldFormat" or EventName == "vs/vsproject/xmlparser/xmakehelper/isprojectfileinoldformat"
| summarize count() by EventName

Backport QB bugs

• 17.10: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2284057
• 17.8: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2287520
• 16.11: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2287521
• 15.9: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2287522

[JanKrivanek]

Verification needs to be done for each backported version - and copied to the appropriate ADO bug.
It needs to be done for the English and single non-English locale.
It should match the results that are outlined below as sample steps - those are for 17.12/17.13. The bug for 17.10 has the sample verification for 17.10. The 17.8, 16.11 and 15.9 needs to be tested and results added

Backport verification steps:

• Download sample old project file (additional files are not needed): https://devdiv.visualstudio.com/Personal/_git/matclark?path=%2Ftools%2FXmlSerializerPreCompiler%2FBackup%2FXmlSerializerPreCompiler%2FXmlSerializerPreCompiler.csproj&_a=contents&version=GBmain
• Open in VS and verify the new wording appears in the dialog:
  
• Verify the project is loaded after conversion:
  
• Verify that the project was converted to MSBuild format:
  
• Verify that upgrade dialog has the new warning wording:
  

Alter localization:

• Run installer
• Add Lang pack and remove English
  
• Then open VS - it should be in the selected locale:
  
• Run the 'Backport verification steps' above, with the current locale

[JanKrivanek]

So the 17.10 PR - https://devdiv.visualstudio.com/DevDiv/_git/a290117c-5a8a-40f7-bc2c-f14dbe3acf6d - was finally fully sorted out, tested and approved. We now need to backport+repeat for other 3 remaining PRs.

High level, what needs to be done (largely sourced from https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/40758/Localization-Servicing-in-Dev-17):

• Backport localization changes into Localize repo, from https://devdiv.visualstudio.com/DevDiv/_git/80eae3e6-fe98-458b-a2d4-5fa8f4d0e465/pullrequest/587046 - the branches naming need to folllow the naming scheme of the matching VS branches (plus the 'loc' suffix) - similarly as the sample PR into rel/d17.10loc
• Add me and Cristiano as reviewers - ping us if needed for timely signoff and merge
• Then the top of newly created branch need to be referenced from the VS PRs (all that's needed is to switch the branch in the local git where you have the PR checked out - ping me for details if needed. The VS wiki is bit confusing in this step)
• Then backport or manually transfer all other remaining changes from the 17.10 PR (it should be basicaly just those revision.txt changes)
• Once done, produce and install a build for the PR (https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/29319/Install-a-VS-Build-from-a-PR) and verify that the localization changes were properly applied (as described in the previous comment on this bug)
• Then ping me and we'll get through the approval paperwork