-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Core MSBuild is missing the LC task #2006
Comments
From @alienisty on April 24, 2017 2:1 Note that building the project with MSBuild provided with Visual Studio 2017 builds the project fine. |
I'm also experiencing this problem. I tried pointing our build script to MSBuild.exe in the Visual Studio installation path (..\Program Files (x86)..) but I still get this error. |
The LC task wasn't ported to .NET Core because The best way to deal with this today is to use full-framework @rustyhann, you're saying that's not working for you, which is unexpected. How exactly are you invoking the build? Could you share a diagnostic-level build log? |
Thank you for the quick reply, I'm working on generating a diagnostic log now. While that's running I can provide some background on our project. We started the project as a .NET Core project (using dotnet new), then changed the target to "net462". We're doing this as a way to move to .NET Core completely while we migrate our legacy libraries. The full path we're using in our build script is: "'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\15.0\Bin\MSBuild.exe'" We switched to this when we migrated to Visual Studio 2017. It solved most of our build issues until we ran into the lc.exe error. I'll post the diagnostic build log when it's finished. --Update I've stored the file in OneDrive and sent a link. |
When this issue will be fixed? I faced the same issue with Teletik license file. |
You can work around this by building with MSBuild and deploying with MSDeploy. The .Net Core tools will not work. The root issue for our scenario was dotnet publish was calling dotnet build. The no-compile option was deprecated in dotnet build. Even if we used MSBuild before calling dotnet publish we still had the issue. Switching to MSDeploy was the answer. |
Makes sense. But does .NET Core 3's support of WinForms controls (on Windows) change things? |
That's a good question. @merriemcgaw do you know if there are plans to bring |
Thanks for forwarding on the question. Note that even if the "dotnet" command does not get support, a tweak to the (.NET Framework) msbuild task would still be useful. Similarly to #2836, (.NET Framework) msbuild passes giant command line arguments to lc.exe, when targetting netcoreapp3.0. |
I know it's been discussed, but I don't know where the discussions have landed yet. |
Running desktop lc.exe on core assemblies is busted. See https://github.com/dotnet/corefx/issues/24200#issuecomment-461803927. I think this needs to be fixed. We have had a few customers ask for the licensing functionality in netcore 3.0. |
@ericstj Thanks for pointing to the issue I faced. I'd like to add we need this not just for licensing components/controls but also plain class libraries. In fact right now for .NET core we are trying this only for the plain class library case. |
@sansjunk thanks for the scenario explanation. I will be working with my team to make a plan for when/how we migrate lc.exe support to Core. |
Should we move this issue to the winforms repo? |
WPF uses the same licensing model |
Is this issue expected to be fixed for the final .NET Core 3.0 release? |
This issue was moved to dotnet/winforms#1462 |
From @alienisty on April 24, 2017 1:58
Steps to reproduce
Just create a project with a licenses.licx file definition and build the project with
Expected behavior
The project builds and the license information are compiled in the binaries
Actual behavior
The following error is raised:
Environment data
dotnet --info
output:Copied from original issue: dotnet/cli#6389
The text was updated successfully, but these errors were encountered: